Skip to content
This repository has been archived by the owner. It is now read-only.

[PAN-2009] - Fix cluster clean start after stop in Acceptance tests #1546

Conversation

@usmansaleem
Copy link
Member

commented Jun 11, 2019

PR description

Allow a cluster to be restarted after a stop.

  • Clear bootnodes on cluster start
  • Cleaner logic to pass bootnodes list only to non-boot nodes in cluster startNode
  • Do not shutdown pantheonNodeRunner from stop method
  • Additional call to stop method from close method in Cluster
  • Fix getBootnodes to setBootnodes in NodeConfiguration
  • Initialise PluginContextImpl once per node in ThreadPantheonNodeRunner
    (allows clean start after a close)
  • Stop plugins in stopNode and shutdown methods of ThreadPantheonNodeRunner
  • Add new acceptance test for a cluster to clean start after stop
usmansaleem added 3 commits Jun 11, 2019
Acceptance tests - Fix cluster restart
 - Clear bootnodes on cluster start
 - Pass bootnodes list only to non-boot nodes in cluster startNode
 - Do not shutdown pantheonNodeRunner from stop method
 - Call stop from cluster close method
 - Fix getBootnodes to setBootnodes in NodeConfiguration
 - Init outputProcessorExecutor in startNode in ProcessPantheonNodeRunner
    (allows clean start after a close or shutdown)
 - Init PluginContextImpl once per node in ThreadPantheonNodeRunner
    (allows clean start after a close or shutdown)
 - Add new acceptance test for a cluster to clean start after stop
 - Allow PantheonPluginContextImpl to clean start plugins after stop

Signed-off-by: Usman Saleem <usman@usmans.info>

@usmansaleem usmansaleem marked this pull request as ready for review Jun 11, 2019

@usmansaleem usmansaleem requested a review from ajsutton Jun 11, 2019

@macfarla
Copy link
Member

left a comment

LGTM

usmansaleem added 4 commits Jun 11, 2019
@ajsutton
Copy link
Member

left a comment

LGTM.

@usmansaleem usmansaleem merged commit 115ffab into PegaSysEng:master Jun 11, 2019

2 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@usmansaleem usmansaleem deleted the usmansaleem:bug/fix_acceptance_test_cluster_restart branch Jun 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.