Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAN-2877] Switch to using metric names from EIP-2159 #1634

Merged
merged 6 commits into from Jul 11, 2019

Conversation

Projects
None yet
2 participants
@ajsutton
Copy link
Member

commented Jul 3, 2019

PR description

Switches metric names to follow EIP-2159. Same metrics being captured, just using the standard names now.

Probably should give the EIP a bit of time to bake and get feedback before actually merging to avoid having to change twice if the EIP changes.

ajsutton added some commits Jul 3, 2019

@shemnon
Copy link
Member

left a comment

LGTM. Now is fine.

ajsutton added some commits Jul 11, 2019

@ajsutton ajsutton merged commit 7366ac3 into PegaSysEng:master Jul 11, 2019

2 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ajsutton ajsutton deleted the ajsutton:eip-2159 branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.