Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables should be more distinct #440

Closed
silverhook opened this issue Jul 14, 2019 · 9 comments

Comments

@silverhook
Copy link
Member

@silverhook silverhook commented Jul 14, 2019

Tables in Pelican Elegant are very simple and un-elegant. Case in point:

…the visual representation would be:

| | | | | | | | | | |   |
|----:|:----:|----:|:----:|----:|:----:|----:|:----:|----:|:----:|------|
|     |   M  |  | **_O_** |   |  **_N_** |   |  T |   |  Y |     |
|  0 |    |  **_1_** |         |  **_2_** |          |  **_3_** |    |  4 |    |  5   |
| -5 |    | **_-4_** |         | **_-3_** |          | **_-2_** |    | -1 |    | None |

As you can see, this logic works for both positive and negative numbers as well as mixing the two in sequences.

produces this:
Screenshot_20190714_143843
https://matija.suklje.name/understanding-how-python-counts

Perhaps adding alternating backgrounds for the fields would help here to make it more appealing and easier to read as table.

@iranzo

This comment has been minimized.

Copy link
Member

@iranzo iranzo commented Aug 1, 2019

I would suggest options to either use lines, alternate colours, etc not to force just one format.

BTW (off topic), some editors allow 'formatting' the visual 'code' representation so that it looks more 'similar' to final result:

image

It adds spaces, etc but seems easier to 'see'

@talha131

This comment has been minimized.

Copy link
Member

@talha131 talha131 commented Aug 1, 2019

I would suggest options to either use lines, alternate colours, etc not to force just one format.

This is the style I am working on

Adding options is great but how would user specify which option to use in Markdown, unless we create a Pelican plugin for this purpose?

I say we offer a sensible default that is good enough for most of the users.

BTW (off topic), some editors allow 'formatting' the visual 'code' representation so that it looks more 'similar' to final result:

If you use prettier via Git hook, then it does this automatically for you.

https://elegant.oncrashreboot.com/use-pre-commit-git-hooks

@talha131

This comment has been minimized.

Copy link
Member

@talha131 talha131 commented Aug 1, 2019

Note that the in the image I provided,

  1. Table is bordered
  2. Alternating Rows have background color
@talha131

This comment has been minimized.

Copy link
Member

@talha131 talha131 commented Aug 10, 2019

Fixed

@talha131 talha131 closed this Aug 10, 2019
talha131 added a commit that referenced this issue Aug 10, 2019
fix #440
talha131 pushed a commit that referenced this issue Aug 22, 2019
# [4.0.0](V3.2.0...V4.0.0) (2019-08-22)

### Bug Fixes

* **admonition:** an artifact in border behind the title ([88113c3](88113c3))
* **admonition:** reduce border radius to match radii of other components ([de08d20](de08d20)), closes [#490](#490)
* **admonition:** remove box shadow ([d059db8](d059db8)), closes [#490](#490)
* **admonition:** remove text-shadow from heading ([1c889da](1c889da)), closes [#490](#490)
* **clean URL:** default URL of categories, tags and archives fails on some servers ([3c7df6a](3c7df6a)), closes [#280](#280) [#276](#276)
* **comments:** W3C validation errors ([76a1f26](76a1f26))
* **disqus:** remove SITEURL condition to show Disqus comments section ([753d5a5](753d5a5))
* **lang:** do not override default value of DEFAULT_LANG set by Pelican ([d6c60c2](d6c60c2))
* **social:** reduce icon sizes in the sidebar ([c769ba3](c769ba3))
* **social:** use nofollow for social links in the sidebar ([50cff87](50cff87))
* **social:** W3C validation error ([ec4521e](ec4521e))
* **table:** reduce border radius to match radii of other components ([7eaaa96](7eaaa96))
* **w3c validation:** remove incorrect usage of article tag ([e8231e0](e8231e0)), closes [#251](#251)
* **w3c validation:** remove obsolete charset attribute ([8deb285](8deb285)), closes [#251](#251)
* **w3c validation:** remove redundant article tag ([d07c27e](d07c27e)), closes [#251](#251)
* **w3c validation:** remove redundant sections without heading ([df9221f](df9221f)), closes [#251](#251)
* **w3c validation:** remove type and language attributes ([b700224](b700224)), closes [#251](#251)
* **w3c validation:** update CSS rules ([0b78d46](0b78d46)), closes [#251](#251)

### Features

* **404:** auto fill search box with URL fragment that was not found ([c0a7f47](c0a7f47))
* **admonition:** add box shadow ([246f826](246f826))
* **admonition:** border color should match the title color ([1adadbe](1adadbe))
* **admonition:** increase contrast of title ([7fb82cc](7fb82cc))
* **admonition:** use svg image instead of font-awesome icon ([e7c4029](e7c4029)), closes [#487](#487)
* **clean url:** support clean URL for search page ([088791e](088791e))
* **comments:** add support for utterances comment system ([a2151cc](a2151cc)), closes [#288](#288)
* **quotes:** improve style and remove font-awesome for quote icon ([9ef3ac8](9ef3ac8)), closes [#487](#487)
* **social:** add icons for 7 more websites ([8dcf8fa](8dcf8fa)), closes [#494](#494)
* **social:** use svg icons instead of font-awesome ([19f458b](19f458b))
* **table:** add style rule to make tables pop out ([6a8500b](6a8500b)), closes [#440](#440)

### Performance Improvements

* **admonition:** add attributes to svg iamges ([a740a60](a740a60))
* **requests:** remove font awesome ([7c20145](7c20145)), closes [#487](#487)

### BREAKING CHANGES

* **requests:** We have removed font awesome. Now we use svg images for all icons. This will result
in one less web request, which in turn will improve your websites performance.
* **social:** Style customization and configuration of social icons
in the sidebar has changed.

New icons have better colors and bigger sizes.
* **clean URL:** To enable clean URLs for tags, categories and archives,
first configure your server to support clean URLs. Then set `TAGS_URL`,
`CATEGORIES_URL` and `ARCHIVES_URL` to `"tags"`, `"categories"` and
`"archives"` respectively.
@talha131

This comment has been minimized.

Copy link
Member

@talha131 talha131 commented Aug 22, 2019

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@talha131 talha131 added the released label Aug 22, 2019
@ptkin

This comment has been minimized.

Copy link

@ptkin ptkin commented Sep 18, 2019

Hi @silverhook , I met the same issue as you, i.e., there were no borders or background colors with the rendered tables.

But I found that I was using an old version of the Elegant theme by mistake. The latest version is v4.0.0, while the version involved by the getpelican/pelican-themes repo is v3.0.0. So I remove the old version and reinstall the latest one, and now it works!

@talha131

This comment has been minimized.

Copy link
Member

@talha131 talha131 commented Sep 18, 2019

@ptkin may I know how you update the Elegant theme and how do you get to know about our new releases?

@ptkin

This comment has been minimized.

Copy link

@ptkin ptkin commented Sep 18, 2019

Updating themes

I just remove the old version by pelican-themes -r elegant, clone the latest repo of Elegant, and reinstall it by pelican-themes -i path/to/elegant.

Knowing about new releases

I'm new to Pelican, so I'm looking for an "elegant" theme for myself today. And that's it, the Elegant theme! When I meet this problem, I guess there may be something mismatching, then I notice that the version of the theme in the getpelican/pelican-themes repo doesn't match the latest version, so I tried to update the theme and finally solve the problem smoothly. This theme is really nice, I like it and thank you very much.

@talha131

This comment has been minimized.

Copy link
Member

@talha131 talha131 commented Sep 30, 2019

@ptkin thank you for your response.

Knowing about new releases

We have a newsletter that you can subscribe to, to get notification about new releases in your inbox.

See the email field in the sidebar.

https://elegant.oncrashreboot.com/version-4-0-0-release-notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.