Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Modified (Last Updated) date not formatted to locale/dateformat #613

Closed
2 of 3 tasks
gertvdijk opened this issue May 30, 2020 · 1 comment
Closed
2 of 3 tasks

[BUG] Modified (Last Updated) date not formatted to locale/dateformat #613

gertvdijk opened this issue May 30, 2020 · 1 comment
Labels
bug Well, it shouldn’t be doing that. Let’s fix it! released
Milestone
2020 - Q2

Comments

@gertvdijk
Copy link
Contributor

Mandatory Step

  • I am using latest production release of Elegant

Recommended Step

  • I have attached link to my blog source code repository, so that developers can try to reproduce the issue at the end
  • I can't my source code but I have linked my pelican configuration files to help developers reproduce the issue

Description

Describe the bug
With a date format set in pelicanconf.py (e.g. DEFAULT_DATE_FORMAT), the Date shows up correctly, but the and Modified field shows in a fixed but dependent on LOCALE format.

Relevant pelicanconf.py:

DEFAULT_DATE_FORMAT = ('en_US.UTF-8', '%d %b %Y, %H:%M')

Article Markdown:

Date: 2014-10-30 12:00
Modified: 2017-08-03 0:00

I expect both fields to show the same, but they don't, as can be seen below in the screenshot.

To Reproduce

See description.

Expected behavior
Be consistent in date formatting to both Publish time and Modified time.

Screenshots
Screenshot from 2020-05-30 13-38-02

Desktop (please complete the following information):

not relevant

Smartphone (please complete the following information):

not relevant

Additional context

Using Pelican 4.2.0, also master branch of Elegant is affected.

Seems only partially fixed in 1da552c for only the Published date format, so I will provide a PR with the fix to also handle this in Modified subtemplate.
@gertvdijk gertvdijk added the bug Well, it shouldn’t be doing that. Let’s fix it! label May 30, 2020
gertvdijk added a commit to gertvdijk/pelican-elegant that referenced this issue May 30, 2020
@gertvdijk
Use locale formatted date in article modified (Last Updated)
4dd4481 
This applies the same fix as with the Published date format in commit
1da552c.

Fixes Pelican-Elegant#613
gertvdijk added a commit to gertvdijk/pelican-elegant that referenced this issue May 30, 2020
@gertvdijk
fix(article): use locale formatted Modified (Last Updated) date
d52de5d 
This applies the same fix as with the Published date format in commit
1da552c.

Fixes Pelican-Elegant#613
gertvdijk added a commit to gertvdijk/pelican-elegant that referenced this issue May 30, 2020
@gertvdijk
fix(article): use locale formatted Modified (Last Updated) date
8fffca6 
This applies the same fix as with the Published date format in commit
1da552c.

Fixes Pelican-Elegant#613
@gertvdijk gertvdijk mentioned this issue May 30, 2020
Merged
5 tasks
gertvdijk added a commit to gertvdijk/pelican-elegant that referenced this issue May 31, 2020
@gertvdijk
fix(article): use locale formatted Modified (Last Updated) date
aefa236 
This applies the same fix as with the Published date format in commit
1da552c.

Fixes Pelican-Elegant#613
@talha131 talha131 added this to the 2020 - Q2 milestone May 31, 2020
talha131 pushed a commit that referenced this issue Jun 13, 2020
@gertvdijk @talha131
fix(article): use locale formatted Modified (Last Updated) date
5823306 
This applies the same fix as with the Published date format in commit
1da552c.

Fixes #613
@ishigoya ishigoya mentioned this issue Nov 22, 2020
Closed
talha131 pushed a commit that referenced this issue May 1, 2021
@semantic-release-bot
chore(release): 5.4.0 [skip ci]
9c5d844 
# [5.4.0](V5.3.0...V5.4.0) (2021-05-01)

### Bug Fixes

* allow PLUGINS to be None ([491228f](491228f))
* **article:** use locale formatted Modified (Last Updated) date ([5823306](5823306)), closes [#613](#613)

### Features

* **analytics:** add support for Modern Google Analytics gtag ([7f5d4c5](7f5d4c5))
* **gallery:** add support for creating PhotoSwipe gallery from the Instagram ([c3bbfdb](c3bbfdb))
* **gallery:** add support for the Instagram album with multiple images ([cd567cf](cd567cf))
@talha131
Copy link
Member

talha131 commented May 1, 2021

:tada: This issue has been resolved in version 5.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Well, it shouldn’t be doing that. Let’s fix it! released
Milestone
2020 - Q2
Development

No branches or pull requests
2 participants
@talha131 @gertvdijk