Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow symlink arrow to be "->" instead of "⇒" #409

Closed
planet36 opened this issue Sep 8, 2020 · 5 comments · Fixed by #436
Closed

Feature request: allow symlink arrow to be "->" instead of "⇒" #409

planet36 opened this issue Sep 8, 2020 · 5 comments · Fixed by #436
Assignees
Labels
kind/enhancement Enhancement on current feature status/in-progress

Comments

@planet36
Copy link

planet36 commented Sep 8, 2020

On my system, the rightwards double arrow character is not visually distinctive from a bold hyphen.

Please allow (maybe with an option or env var) the symlink arrow to be "->" instead of "⇒".

@zwpaper zwpaper added the kind/enhancement Enhancement on current feature label Sep 21, 2020
@zwpaper
Copy link
Member

zwpaper commented Sep 22, 2020

Add a option for rendering this would be an easy solution, what do u think? @meain

@meain
Copy link
Member

meain commented Sep 22, 2020

Yeah, I have a few concerns though:

  • does the flag only affect or all future non ascii chars if any
  • what should the flag be (--only-ascii ?)
  • should the flag be => or -> as some fonts have - rendered below middle

@zwpaper
Copy link
Member

zwpaper commented Sep 23, 2020

@meain actually, there is a more complicated solution in my mind, as u mentioned maybe the flag may effect all chars.

How about we add themes for all those customized requests, like this issue, #333, and the description in README.

we can use a theme file to describe the =>, icons, also colors.

@meain
Copy link
Member

meain commented Sep 23, 2020

Yeah, that sounds good. Config would be a better place for this.

@planet36
Copy link
Author

It works great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement on current feature status/in-progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants