Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special treatment of overflow in sections/highlights. #6378

Merged
merged 2 commits into from Jul 9, 2019

Conversation

Projects
None yet
2 participants
@bakert
Copy link
Member

commented Jul 9, 2019

As it currently stands this clips the loading spinner and part of the L of
Loading. If we just remove the overflow-x: auto then tables like /rotation/
that don't get footable behavior overflow into the right margin. So we remove
overflow: visible on narrow view also. I'm not sure what this was showing
before but all interestingness remains visible so I think this is ok.

bakert added some commits Jul 9, 2019

Remove special treatment of overflow in sections/highlights.
As it currently stands this clips the loading spinner and part of the L of
Loading. If we just remove the overflow-x: auto then tables like /rotation/
that don't get footable behavior overflow into the right margin. So we remove
overflow: visible on narrow view also. I'm not sure what this was showing
before but all interestingness remains visible so I think this is ok.

@vorpal-buildbot vorpal-buildbot merged commit 2cb20f6 into master Jul 9, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pdm/automerge Ready to merge
@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Seen on LOGS (created by @bakert and merged by @vorpal-buildbot 53 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Seen on PROD (created by @bakert and merged by @vorpal-buildbot 1 minute and 5 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.