Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logsite API improvements #6504

Merged
merged 4 commits into from Aug 12, 2019

Conversation

@silasary
Copy link
Member

commented Aug 12, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

commented Aug 12, 2019

Codecov Report

Merging #6504 into master will increase coverage by 0.02%.
The diff coverage is 57.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6504      +/-   ##
==========================================
+ Coverage   42.04%   42.07%   +0.02%     
==========================================
  Files         215      215              
  Lines       13098    13120      +22     
  Branches     2025     2027       +2     
==========================================
+ Hits         5507     5520      +13     
- Misses       7352     7354       +2     
- Partials      239      246       +7
Impacted Files Coverage Δ
shared/serialization.py 0% <0%> (ø) ⬆️
logsite/db.py 88.4% <100%> (ø) ⬆️
logsite/api.py 42.85% <56.25%> (+6.27%) ⬆️
logsite/data/match.py 75% <60%> (-1.67%) ⬇️
logsite/data/game.py 83.87% <60%> (-4.6%) ⬇️
logsite/data/tournament.py 96.55% <66.66%> (-3.45%) ⬇️
maintenance/elo.py 0% <0%> (ø) ⬆️
magic/multiverse.py 3.93% <0%> (ø) ⬆️
github_tools/webhooks.py 0% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f5515...f7540c9. Read the comment docs.

@vorpal-buildbot vorpal-buildbot merged commit 9edff46 into master Aug 12, 2019

7 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 57.57% of diff hit (target 42.04%)
Details
codecov/project 42.07% (+0.02%) compared to 27f5515
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pdm/automerge Ready to merge
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Seen on LOGS (created by @silasary and merged by @vorpal-buildbot 56 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Seen on PROD (created by @silasary and merged by @vorpal-buildbot 1 minute and 7 seconds ago) Please check your changes!

@silasary silasary deleted the logsite branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.