Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try and cast match_id unless it exists #6574

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@bakert
Copy link
Member

commented Oct 8, 2019

No description provided.

@TravisBuddy

This comment has been minimized.

Copy link

commented Oct 8, 2019

Hey @bakert,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: e2d7af40-e967-11e9-93dd-b3a5547eb4f4
@codecov

This comment has been minimized.

Copy link

commented Oct 8, 2019

Codecov Report

Merging #6574 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6574      +/-   ##
==========================================
- Coverage   42.93%   42.92%   -0.01%     
==========================================
  Files         213      213              
  Lines       12874    12875       +1     
  Branches     1967     1968       +1     
==========================================
  Hits         5527     5527              
- Misses       7108     7109       +1     
  Partials      239      239
Impacted Files Coverage Δ
decksite/admin.py 43.57% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1244c...fd43686. Read the comment docs.

@vorpal-buildbot vorpal-buildbot merged commit 24d3008 into master Oct 8, 2019
6 checks passed
6 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Summary no rules match, no planned actions
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pdm/automerge Ready to merge
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

Seen on LOGS (created by @bakert and merged by @vorpal-buildbot 1 minute and 3 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

Seen on PROD (created by @bakert and merged by @vorpal-buildbot 1 minute and 13 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.