Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to live decktable on person and archetype detail pages. #6756

Merged
merged 9 commits into from Nov 7, 2019

Conversation

@bakert
Copy link
Member

bakert commented Nov 7, 2019

No description provided.

@TravisBuddy

This comment has been minimized.

Copy link

TravisBuddy commented Nov 7, 2019

Hey @bakert,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: e1289290-0177-11ea-82f1-cf3ba55cf6d0
@vorpal-buildbot vorpal-buildbot merged commit 4248ab8 into master Nov 7, 2019
6 checks passed
6 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Summary no rules match, no planned actions
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pdm/automerge Ready to merge
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #6756 into master will increase coverage by 0.08%.
The diff coverage is 65.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6756      +/-   ##
==========================================
+ Coverage   41.84%   41.93%   +0.08%     
==========================================
  Files         256      257       +1     
  Lines       13273    13297      +24     
  Branches     2010     2012       +2     
==========================================
+ Hits         5554     5576      +22     
+ Misses       7472     7470       -2     
- Partials      247      251       +4
Impacted Files Coverage Δ
decksite/data/archetype.py 46.2% <0%> (ø) ⬆️
decksite/views/archetype.py 31.7% <0%> (+1.47%) ⬆️
decksite/api.py 36.16% <0%> (+0.63%) ⬆️
decksite/data/query_test.py 100% <100%> (ø)
decksite/data/query.py 70.45% <63.63%> (-5.55%) ⬇️
decksite/league.py 34.21% <0%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a097227...c8fbbfc. Read the comment docs.

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Nov 7, 2019

Seen on LOGS (created by @bakert and merged by @vorpal-buildbot 1 minute and 9 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Nov 7, 2019

Seen on PROD (created by @bakert and merged by @vorpal-buildbot 1 minute and 32 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.