Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move archetype detail page to react table. Speed up spoiler inserts. #6758

Merged
merged 10 commits into from Nov 7, 2019

Conversation

@bakert
Copy link
Member

bakert commented Nov 7, 2019

No description provided.

bakert added 10 commits Nov 7, 2019
…urpose.

Add add_to_cache for when we want to poke values in without tearing down the whole db.
…aches

This takes the run time down from 30s -> 4s on local for me. Most of the time
saving is in whoosh reindexing but all steps (except insert_cards) are faster.

Fixes #6320.
The CSS changes are because of a conflict between td.archetype and archetype
in the archetype tree.
@TravisBuddy

This comment has been minimized.

Copy link

TravisBuddy commented Nov 7, 2019

Hey @bakert,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a8807e10-01ab-11ea-82f1-cf3ba55cf6d0
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #6758 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6758      +/-   ##
==========================================
- Coverage   41.93%   41.88%   -0.05%     
==========================================
  Files         257      257              
  Lines       13297    13314      +17     
  Branches     2012     2019       +7     
==========================================
+ Hits         5576     5577       +1     
- Misses       7476     7487      +11     
- Partials      245      250       +5
Impacted Files Coverage Δ
maintenance/reprime_cache.py 0% <0%> (ø) ⬆️
decksite/scrapers/bugged_cards.py 0% <0%> (ø) ⬆️
discordbot/commands/update.py 0% <0%> (ø) ⬆️
magic/multiverse.py 5.45% <0%> (-0.23%) ⬇️
magic/oracle.py 27.41% <0%> (-0.92%) ⬇️
logsite/api.py 42.85% <0%> (ø) ⬆️
maintenance/elo.py 0% <0%> (ø) ⬆️
decksite/views/person_achievements.py 35% <0%> (ø) ⬆️
decksite/data/rule.py 23.63% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4248ab8...3c70a81. Read the comment docs.

@vorpal-buildbot vorpal-buildbot merged commit 49b447c into master Nov 7, 2019
6 checks passed
6 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Summary no rules match, no planned actions
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pdm/automerge Ready to merge
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Nov 7, 2019

Seen on LOGS (created by @bakert and merged by @vorpal-buildbot 53 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Nov 7, 2019

Seen on PROD (created by @bakert and merged by @vorpal-buildbot 1 minute and 23 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.