Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide page size choose when num decks < 20. (Sligthly) better github messages. #6761

Merged
merged 7 commits into from Nov 7, 2019

Conversation

@bakert
Copy link
Member

bakert commented Nov 7, 2019

No description provided.

@TravisBuddy

This comment has been minimized.

Copy link

TravisBuddy commented Nov 7, 2019

Hey @bakert,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 6eccc290-01b6-11ea-82f1-cf3ba55cf6d0
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #6761 into master will increase coverage by 0.01%.
The diff coverage is 16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6761      +/-   ##
==========================================
+ Coverage   41.88%   41.89%   +0.01%     
==========================================
  Files         257      257              
  Lines       13314    13317       +3     
  Branches     2019     2020       +1     
==========================================
+ Hits         5576     5579       +3     
+ Misses       7493     7486       -7     
- Partials      245      252       +7
Impacted Files Coverage Δ
decksite/api.py 36.16% <ø> (ø) ⬆️
shared/repo.py 3.7% <0%> (+0.06%) ⬆️
decksite/data/card.py 67.08% <100%> (ø) ⬆️
decksite/data/query.py 69.38% <60%> (-1.07%) ⬇️
logsite/api.py 42.85% <0%> (ø) ⬆️
maintenance/elo.py 0% <0%> (ø) ⬆️
magic/multiverse.py 5.45% <0%> (ø) ⬆️
decksite/views/person_achievements.py 35% <0%> (ø) ⬆️
decksite/data/rule.py 23.63% <0%> (ø) ⬆️
logsite/data/match.py 75% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e6ac6...e44f999. Read the comment docs.

@vorpal-buildbot vorpal-buildbot merged commit 0a5aa9a into master Nov 7, 2019
6 checks passed
6 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Summary no rules match, no planned actions
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pdm/automerge Ready to merge
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Nov 7, 2019

Seen on LOGS, PROD (created by @bakert and merged by @vorpal-buildbot 1 minute and 20 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.