Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix images. #6802

Merged
merged 2 commits into from Nov 12, 2019
Merged

Fix images. #6802

merged 2 commits into from Nov 12, 2019

Conversation

@bakert
Copy link
Member

bakert commented Nov 12, 2019

No description provided.

bakert added 2 commits Nov 12, 2019
It was breaking card page images.

This reverts commit bc6887b.
@TravisBuddy

This comment has been minimized.

Copy link

TravisBuddy commented Nov 12, 2019

Hey @bakert,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 69852b30-05a1-11ea-a86a-e5201e811db5
@vorpal-buildbot vorpal-buildbot merged commit ae61714 into master Nov 12, 2019
6 checks passed
6 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Summary no rules match, no planned actions
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pdm/automerge Ready to merge
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #6802 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6802      +/-   ##
==========================================
+ Coverage   31.76%   31.77%   +<.01%     
==========================================
  Files         260      260              
  Lines       13507    13496      -11     
  Branches     2044     2041       -3     
==========================================
- Hits         4291     4288       -3     
+ Misses       9110     9095      -15     
- Partials      106      113       +7
Impacted Files Coverage Δ
decksite/view.py 25.18% <0%> (-0.09%) ⬇️
logsite/api.py 42.85% <0%> (ø) ⬆️
decksite/views/card.py 27.58% <0%> (ø) ⬆️
maintenance/elo.py 0% <0%> (ø) ⬆️
magic/multiverse.py 5.47% <0%> (ø) ⬆️
decksite/views/person_achievements.py 35% <0%> (ø) ⬆️
decksite/data/rule.py 23.63% <0%> (ø) ⬆️
logsite/data/match.py 73.43% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92511aa...5a2a3cf. Read the comment docs.

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Nov 12, 2019

Seen on LOGS (created by @bakert and merged by @vorpal-buildbot 41 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Nov 12, 2019

Seen on LOGS (created by @bakert and merged by @vorpal-buildbot 49 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Nov 12, 2019

Seen on PROD (created by @bakert and merged by @vorpal-buildbot 58 seconds ago) Please check your changes!

1 similar comment
@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Nov 12, 2019

Seen on PROD (created by @bakert and merged by @vorpal-buildbot 58 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.