Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting and `dev.py build` #6909

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@silasary
Copy link
Member

silasary commented Dec 2, 2019

No description provided.

@TravisBuddy

This comment has been minimized.

Copy link

TravisBuddy commented Dec 2, 2019

Hey @silasary,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: dab5f100-14be-11ea-a5d4-6b7b0fca08ad
@vorpal-buildbot vorpal-buildbot merged commit 030d288 into master Dec 2, 2019
7 checks passed
7 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Summary no rules match, no planned actions
Details
codecov/project 40.98% (+<.01%) compared to df0c0d9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pdm/automerge Ready to merge
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #6909 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6909      +/-   ##
==========================================
- Coverage   40.99%   40.98%   -0.01%     
==========================================
  Files         272      272              
  Lines       13625    13625              
  Branches     2043     2043              
==========================================
- Hits         5585     5584       -1     
+ Misses       7798     7792       -6     
- Partials      242      249       +7
Impacted Files Coverage Δ
decksite/view.py 61.12% <0%> (ø) ⬆️
decksite/data/competition.py 62.96% <0%> (-2.47%) ⬇️
logsite/api.py 41.17% <0%> (ø) ⬆️
maintenance/elo.py 0% <0%> (ø) ⬆️
magic/multiverse.py 5.42% <0%> (ø) ⬆️
decksite/views/person_achievements.py 35% <0%> (ø) ⬆️
decksite/data/rule.py 23.42% <0%> (ø) ⬆️
logsite/data/match.py 75% <0%> (ø) ⬆️
decksite/league.py 34.76% <0%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e47f4c2...358e0e6. Read the comment docs.

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Dec 2, 2019

Seen on LOGS (created by @silasary and merged by @vorpal-buildbot 1 minute and 19 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Dec 2, 2019

Seen on LOGS (created by @silasary and merged by @vorpal-buildbot 1 minute and 21 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Dec 2, 2019

Seen on LOGS (created by @silasary and merged by @vorpal-buildbot 1 minute and 22 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Dec 2, 2019

Seen on LOGS (created by @silasary and merged by @vorpal-buildbot 1 minute and 26 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Dec 2, 2019

Seen on LOGS (created by @silasary and merged by @vorpal-buildbot 1 minute and 29 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Dec 2, 2019

Seen on PROD (created by @silasary and merged by @vorpal-buildbot 1 minute and 35 seconds ago) Please check your changes!

2 similar comments
@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Dec 2, 2019

Seen on PROD (created by @silasary and merged by @vorpal-buildbot 1 minute and 35 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Dec 2, 2019

Seen on PROD (created by @silasary and merged by @vorpal-buildbot 1 minute and 35 seconds ago) Please check your changes!

@@ -216,9 +218,17 @@ def pull_request(argv: List[str]) -> None:
print('>>>> Pull request')
subprocess.check_call(['hub', 'pull-request', *argv])

def build() -> None:

This comment has been minimized.

Copy link
@bakert

bakert Dec 2, 2019

Member

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.