Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try and get mysql port as a str, rather ans an int. #6912

Merged
merged 2 commits into from Dec 2, 2019

Conversation

@bakert
Copy link
Member

bakert commented Dec 2, 2019

Which is what it is.

Which is what it is.
@TravisBuddy

This comment has been minimized.

Copy link

TravisBuddy commented Dec 2, 2019

Hey @bakert,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 4418a520-150f-11ea-a5d4-6b7b0fca08ad
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #6912 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6912   +/-   ##
=======================================
  Coverage   40.99%   40.99%           
=======================================
  Files         272      272           
  Lines       13625    13625           
  Branches     2043     2043           
=======================================
  Hits         5585     5585           
+ Misses       7798     7791    -7     
- Partials      242      249    +7
Impacted Files Coverage Δ
maintenance/dev_db.py 0% <0%> (ø) ⬆️
logsite/api.py 41.17% <0%> (ø) ⬆️
maintenance/elo.py 0% <0%> (ø) ⬆️
decksite/view.py 61.12% <0%> (ø) ⬆️
magic/multiverse.py 5.42% <0%> (ø) ⬆️
decksite/views/person_achievements.py 35% <0%> (ø) ⬆️
decksite/data/rule.py 23.42% <0%> (ø) ⬆️
logsite/data/match.py 75% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 030d288...5b7bc08. Read the comment docs.

@vorpal-buildbot vorpal-buildbot merged commit d496e08 into master Dec 2, 2019
6 checks passed
6 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Summary no rules match, no planned actions
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pdm/automerge Ready to merge
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Dec 2, 2019

Seen on LOGS (created by @bakert and merged by @vorpal-buildbot 1 minute and 6 seconds ago) Please check your changes!

1 similar comment
@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Dec 2, 2019

Seen on LOGS (created by @bakert and merged by @vorpal-buildbot 1 minute and 6 seconds ago) Please check your changes!

@vorpal-buildbot

This comment has been minimized.

Copy link
Contributor

vorpal-buildbot commented Dec 2, 2019

Seen on PROD (created by @bakert and merged by @vorpal-buildbot 1 minute and 49 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.