Delete plxpr transform integration#2853
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2853 +/- ##
==========================================
+ Coverage 96.95% 96.96% +0.01%
==========================================
Files 169 169
Lines 18876 18876
Branches 1799 1798 -1
==========================================
+ Hits 18301 18304 +3
+ Misses 409 407 -2
+ Partials 166 165 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paul0403
approved these changes
May 19, 2026
multiphaseCFD
pushed a commit
that referenced
this pull request
May 19, 2026
**Context:** We no longer want to support or develop applying transforms to the plxpr itself. Instead, we want to force all transforms to be applied in MLIR/ XDSL with the capture pipeline. But we still had some relatively dead code handing around to support them. This removes them. **Description of the Change:** Deletes some code for handling `Transform.plxpr_transform` in the conversion process from plxpr to catalyst-jaxpr. **Benefits:** Prunes out features we don't actually want anymore. **Possible Drawbacks:** This was always experimental, so if anyone is wanting it or depending on it, they are asking for this type of thing to happen. Is a little sad to delete all the code that took so long to develop though. **Related GitHub Issues:** [sc-120025]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
We no longer want to support or develop applying transforms to the plxpr itself. Instead, we want to force all transforms to be applied in MLIR/ XDSL with the capture pipeline.
But we still had some relatively dead code handing around to support them. This removes them.
Description of the Change:
Deletes some code for handling
Transform.plxpr_transformin the conversion process from plxpr to catalyst-jaxpr.Benefits:
Prunes out features we don't actually want anymore.
Possible Drawbacks:
This was always experimental, so if anyone is wanting it or depending on it, they are asking for this type of thing to happen.
Is a little sad to delete all the code that took so long to develop though.
Related GitHub Issues:
[sc-120025]