Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wheels: Addressing changes in PR #279 #356

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Nov 7, 2023

With Changes in PR #279,

  • Disable the warning-as-error build option for 3rd-party backend devices on wheels recipes.
  • Add the new catalyst module to the wheels
  • Fix segfaults with debug_print tests on macOS

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95bb0df) 99.63% compared to head (84978e7) 99.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          44       44           
  Lines        7621     7622    +1     
  Branches      449      449           
=======================================
+ Hits         7593     7594    +1     
  Misses         14       14           
  Partials       14       14           
Files Coverage Δ
runtime/lib/capi/RuntimeCAPI.cpp 100.00% <100.00%> (ø)
runtime/tests/Test_LightningCoreQIS.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliasadi maliasadi changed the title Disable warning-as-error option for 3rd-party devices Updating wheels: Addressing changes in PR #279 Nov 8, 2023
@maliasadi maliasadi changed the title Updating wheels: Addressing changes in PR #279 Update wheels: Addressing changes in PR #279 Nov 8, 2023
@maliasadi
Copy link
Member Author

The wheels are all built successfully and tested 🎉

Copy link
Collaborator

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@dime10 dime10 merged commit 2737a84 into main Nov 8, 2023
20 checks passed
@dime10 dime10 deleted the maa/fix-cis-wextra branch November 8, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants