Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for windows filepaths in dataset module #3504

Merged
merged 5 commits into from Dec 9, 2022

Conversation

timmysilv
Copy link
Contributor

Context:
Windows uses \ as a path separator. Unfortunately, the datasets module matches local paths to S3 bucket paths and doesn't expect local paths to use anything other than /.

Description of the Change:
Convert windows paths to unix-like paths before sending requests to S3.

Benefits:
The dataset module will work as expected on Windows

Possible Drawbacks:
N/A (well.. encouraging people to continue development on Windows is a grey area but I digress 馃槃 )

Related GitHub Issues:
N/A

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #3504 (2e93d52) into master (d2ba09f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3504      +/-   ##
==========================================
- Coverage   99.86%   99.86%   -0.01%     
==========================================
  Files         309      309              
  Lines       27432    27429       -3     
==========================================
- Hits        27396    27393       -3     
  Misses         36       36              
Impacted Files Coverage 螖
pennylane/data/data_manager.py 100.00% <100.00%> (酶)
pennylane/data/dataset.py 100.00% <100.00%> (酶)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick test on windows worked. I think the issue is solved.

@timmysilv timmysilv marked this pull request as ready for review December 9, 2022 15:57
@timmysilv timmysilv enabled auto-merge (squash) December 9, 2022 16:29
@timmysilv timmysilv merged commit c04b622 into master Dec 9, 2022
@timmysilv timmysilv deleted the datasets-windows-support branch December 9, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants