add support for windows filepaths in dataset module #3504
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Windows uses
\
as a path separator. Unfortunately, the datasets module matches local paths to S3 bucket paths and doesn't expect local paths to use anything other than/
.Description of the Change:
Convert windows paths to unix-like paths before sending requests to S3.
Benefits:
The dataset module will work as expected on Windows
Possible Drawbacks:
N/A (well.. encouraging people to continue development on Windows is a grey area but I digress 馃槃 )
Related GitHub Issues:
N/A