Support autodiff and batching in kernel matrix functions #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3742 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 329 329
Lines 28848 28856 +8
=======================================
+ Hits 28797 28805 +8
Misses 51 51
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mudit2812
reviewed
Feb 9, 2023
mudit2812
approved these changes
Feb 9, 2023
Co-authored-by: Mudit Pandey <muditpandey2812@gmail.com>
auto-merge was automatically disabled
February 9, 2023 15:53
Merge queue setting changed
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
mudit2812
added a commit
that referenced
this pull request
Apr 13, 2023
* everything,everywhere,all at once * changelog * add lintable test file * Apply suggestions from code review Co-authored-by: Mudit Pandey <muditpandey2812@gmail.com> --------- Co-authored-by: Mudit Pandey <muditpandey2812@gmail.com> Co-authored-by: Romain Moyard <rmoyard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
There are two utility functions in
pennylane/kernels/utils.py:square_kernel_matrixandkernel_matrix. They are written for Numpy, and partially for Autograd.Description of the Change:
This PR makes the two functions fully compatible with Autograd, JAX, Tensorflow and PyTorch.
In addition it adds batching support to the functions, allowing the kernel to return a one-dimensional instead of a scalar output.
Benefits:
Differentiation/interface support. One can now make use of shot vector execution together with kernels.
Possible Drawbacks:
usual overhead of
qml.math.Related GitHub Issues:
implements #2492