Plugin extra operations #65

cgogolin · 2018-10-05T16:42:22Z

Allows plugins to supply additional Operations and Expectations, which are then automatically accessible along the standard OpenQML Operations form the openqml. and openqml.expectation. contexts.

The device keeps track of which operations it adds and removes them again when the qfunc ends.

This PR in particular solves #44.

The changes are slightly more extensive than I would have wanted, but nothing dramatic. You will see that if you first merge #64:

Adding an removing operations is done in device.__enter__() and device.__exit__(), which are now called again because I have reintroduced a with device: into the qfunc decorator. (@josh146, please comment on whether this will break other things)
I had to move QuantumFunctionError to qnode, where it anyway belongs more naturally, to resolve a dependency loop.

…ions disabled AllPauliZ Expectation fixed generation of DeviceError

fixed calculation of expectation values in the simulator

…uce an error

…but which makes no sense commented out Identity gate in default plugin which seems useless

…lled_plugins

added check of whether the required wires fit on the device

…itional operations small improvements in docstring of qfunc.py moved QuantumFunctionError from device to qnode

moved code to add/remove the extra operations to __enter__() and __exit__()

openqml-pq/openqml_pq/projectq.py

josh146 · 2018-10-05T17:21:34Z

openqml-pq/openqml_pq/projectq.py

@@ -110,6 +110,7 @@ class ProjectQDevice(Device):
    plugin_version = __version__
    author = 'Christian Gogolin'
    _capabilities = {'backend': list(["Simulator", "ClassicalSimulator", "IBMBackend"])}
+    _extra_operations = {'S': S, 'T': T, 'SqrtX': SqrtX, 'SqrtSwap': SqrtSwap, 'AllPauliZ': AllPauliZ}


So is _extra_operations a optional class attribute, that maps openqml.ops.key (attribute loaded dynamically) to openqml_pq.ops.value?

I'll resolve this if it is explained further down, just commenting here while it is fresh in my mind :)

josh146 · 2018-10-05T17:23:22Z

openqml/__init__.py

@@ -21,7 +21,8 @@


 from .configuration import Configuration
-from .device import Device, DeviceError, QuantumFunctionError
+from .device import Device, DeviceError
+from .qnode import QuantumFunctionError


Strangely, I think I had to originally put QuantumFunctionError in device.py because of a dependency loop...

It is no longer used in device.py, so I think now it makes more sense to have it in qnode.py

openqml/plugins/default.py

openqml/device.py

josh146 · 2018-10-05T17:33:21Z

It looks good in the case of the qfunc decorator! The only downside I can think of is that in the more advance use-case, where the user instatiates the QNode object directly, i.e.

def quantum_function():
   qm.RX()
   qm.custom_op()

qnode = QNode(quantum_function, dev1)

will not work without an explicit with dev1: prior to the QNode call.

One solution would be to move the with device: to inside the QNode, since the device is passed to the QNode anyway. That way, the explicit with device: in the example above, and also inside qfunc.py, are no longer needed. In fact, this is what I think was happening originally, back when device was still a context manager? Going through the commit history of master should show this.

cgogolin · 2018-10-05T19:37:02Z

One are the classes missing in ProjectQ, the other are the classes for additional operations in OpenQML. But, no, nothing apart from that.

…

On 5 October 2018 19:19:02 CEST, Josh Izaac ***@***.***> wrote: josh146 commented on this pull request. > @@ -57,7 +57,7 @@ from projectq.ops import (HGate, XGate, YGate, ZGate, SGate, TGate, SqrtXGate, SwapGate, SqrtSwapGate, Rx, Ry, Rz, R, Ph, StatePreparation, HGate, SGate, TGate, SqrtXGate, SqrtSwapGate ) from .ops import (CNOT, CZ, Toffoli, AllZGate, Rot, QubitUnitary) - +from .ops import (S, T, SqrtX, SqrtSwap, AllPauliZ) any reason in particular why these are on a different line? -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #65 (review)

-- Christian Gogolin http://www.cgogolin.de

cgogolin · 2018-10-05T19:37:28Z

Yes, exactly. -- Christian Gogolin http://www.cgogolin.de

cgogolin · 2018-10-05T19:38:08Z

Will do. -- Christian Gogolin http://www.cgogolin.de

cgogolin · 2018-10-05T19:39:08Z

Than that would be the preferred option. Can you make that change, please? -- Christian Gogolin http://www.cgogolin.de

…and __exit__() call reset() manually during init removed already commented Identity operation from default plugin

…mment)

cgogolin · 2018-10-08T08:34:15Z

Replying via email to your comments aparently just put all my replies into this thread instead of treating them as replies to your questions...

With the latest commits I have:

added comments to __enter__() and __exit__()
moved the device context from the qfunc decorator to QNode. This is clearly the cleaner solution, as you outlined above.

cgogolin · 2018-10-08T09:12:12Z

I just finished the classical simulator (I know that this will be of limited use, but it is still nice to support and wasn't much work). With this I think this PR is ready for merging.

co9olguy · 2018-11-01T19:16:29Z

I'm going to close this PR at this point. We have not come to an agreement on the best way to handle plugins importing their own ops. For initial release, we will go with a simple exposure via the plugin's namespace. We can revisit this question for future releases.

cgogolin added 12 commits October 5, 2018 11:30

implemented pre_expectations to support qfuncs with multiple Expectat…

29f98df

…ions disabled AllPauliZ Expectation fixed generation of DeviceError

changed calculation of expectation values in the IBM backend

47f6fb1

fixed calculation of expectation values in the simulator

disabled deallocation in the IBM backend because it now seems to prod…

5da6fe5

…uce an error

fixed typo

e0fe802

various improvements in the test of all installed plugins

1800f93

removed Hermitian gate, which the default plugin claimed to support, …

f5693f3

…but which makes no sense commented out Identity gate in default plugin which seems useless

Merge branch 'projectq_support_multiple_measurements' into test_insta…

c0718e4

…lled_plugins

improved selection of wires for application

b48b1d6

added check of whether the required wires fit on the device

added _extra_operations dictionary with which plugins can provide add…

1db83be

…itional operations small improvements in docstring of qfunc.py moved QuantumFunctionError from device to qnode

cleaned commented import

f49965c

expose various extra ProjectQ gates via _extra_operations

ff1581c

re-introduce a device context

125e1ef

moved code to add/remove the extra operations to __enter__() and __exit__()

cgogolin requested a review from josh146 October 5, 2018 16:42

cgogolin mentioned this pull request Oct 5, 2018

Some Operations and Expectations throw a module 'openqml' has no attribute error #44

Closed

josh146 reviewed Oct 5, 2018

View reviewed changes

openqml-pq/openqml_pq/projectq.py Outdated Show resolved Hide resolved

josh146 reviewed Oct 5, 2018

View reviewed changes

openqml/plugins/default.py Outdated Show resolved Hide resolved

josh146 reviewed Oct 5, 2018

View reviewed changes

openqml/device.py Show resolved Hide resolved

cgogolin added 2 commits October 8, 2018 10:23

added comments and docstrings explaining what is done in __enter__() …

f73845f

…and __exit__() call reset() manually during init removed already commented Identity operation from default plugin

moved with device: context from qfunc to QNode in response to #65 (co…

8313d2a

…mment)

finished the classical simulator

5032a54

co9olguy mentioned this pull request Oct 25, 2018

Best way for plugins to add their own ops/expvals? #97

Closed

co9olguy closed this Nov 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Plugin extra operations #65

Plugin extra operations #65

cgogolin commented Oct 5, 2018 •

edited

Loading

josh146 Oct 5, 2018

josh146 Oct 5, 2018

cgogolin Oct 8, 2018

josh146 commented Oct 5, 2018 •

edited

Loading

cgogolin commented Oct 5, 2018 via email

cgogolin commented Oct 5, 2018 via email

cgogolin commented Oct 5, 2018 via email

cgogolin commented Oct 5, 2018 via email

cgogolin commented Oct 8, 2018

cgogolin commented Oct 8, 2018

co9olguy commented Nov 1, 2018

Plugin extra operations #65

Plugin extra operations #65

Conversation

cgogolin commented Oct 5, 2018 • edited Loading

josh146 Oct 5, 2018

Choose a reason for hiding this comment

josh146 Oct 5, 2018

Choose a reason for hiding this comment

cgogolin Oct 8, 2018

Choose a reason for hiding this comment

josh146 commented Oct 5, 2018 • edited Loading

cgogolin commented Oct 5, 2018 via email

cgogolin commented Oct 5, 2018 via email

cgogolin commented Oct 5, 2018 via email

cgogolin commented Oct 5, 2018 via email

cgogolin commented Oct 8, 2018

cgogolin commented Oct 8, 2018

co9olguy commented Nov 1, 2018

cgogolin commented Oct 5, 2018 •

edited

Loading

josh146 commented Oct 5, 2018 •

edited

Loading