Skip to content

Add host info such as version and encryption to the MSSQL protocol - #720

Closed
Dfte wants to merge 0 commit into
Pennyw0rth:mainfrom
Dfte:main
Closed

Dfte wants to merge 0 commit into
Pennyw0rth:mainfrom
Dfte:main

Conversation

@Dfte

@Dfte Dfte commented Jun 4, 2025 •

Copy link
Copy Markdown
Contributor

Description

This PR adds host information such as the MSSQL version and if encryption is enabled or not:

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)

Checklist:

  • I have ran Ruff against my changes (via poetry: poetry run python -m ruff check . --preview, use --fix to automatically fix what it can)
  • I have added or updated the tests/e2e_commands.txt file if necessary
  • New and existing e2e tests pass locally with my changes
  • If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

@NeffIsBack

Copy link
Copy Markdown
Member

Nice one!

Can you put the class into the nxc/protocols/mssql/ folder and import it from there?

@NeffIsBack NeffIsBack added the enhancement New feature or request label Jun 4, 2025
@Dfte

Dfte commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

Here you go :D

@Dfte

Dfte commented Jun 30, 2025

Copy link
Copy Markdown
Contributor Author

Before merging this, I think I'll push the MSSQL version.py file to Impacket directly so they can integrate it instead of having our own version to maintain. Looks cleaner to me considering what we have been talking about lately ;)!

@NeffIsBack

Copy link
Copy Markdown
Member

Before merging this, I think I'll push the MSSQL version.py file to Impacket directly so they can integrate it instead of having our own version to maintain. Looks cleaner to me considering what we have been talking about lately ;)!

Sounds good 👍 gonna mark it as Draft as long as this is ongoing

@NeffIsBack
NeffIsBack marked this pull request as draft June 30, 2025 18:41
@Dfte Dfte closed this Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants