Conversation
Dfte
requested review from
Marshall-Hallenbeck,
NeffIsBack,
mpgn and
zblurx
as code owners
June 4, 2025 11:43
Member
|
Nice one! Can you put the class into the nxc/protocols/mssql/ folder and import it from there? |
Contributor
Author
|
Here you go :D |
Contributor
Author
|
Before merging this, I think I'll push the MSSQL version.py file to Impacket directly so they can integrate it instead of having our own version to maintain. Looks cleaner to me considering what we have been talking about lately ;)! |
Member
Sounds good 👍 gonna mark it as Draft as long as this is ongoing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds host information such as the MSSQL version and if encryption is enabled or not:
Type of change
Checklist:
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can)