Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source maps do not work with @rollup/plugin-typescript #222

Closed
charlag opened this issue Jan 6, 2022 · 5 comments
Closed

Source maps do not work with @rollup/plugin-typescript #222

charlag opened this issue Jan 6, 2022 · 5 comments

Comments

@charlag
Copy link
Contributor

charlag commented Jan 6, 2022

  1. Clone this repo (0.18.6 = 96db07f)
  2. npm i
  3. go to examples/example-typescript
  4. npm start
  5. Open http://localhost:9001 in browser
  6. See that source maps do not work ("DevTools failed to load source map: Could not load content for nollup-int:///src/enum.js.map: HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME")
@PepsRyuu
Copy link
Owner

PepsRyuu commented Jan 7, 2022

It looks like the TypeScript plugin returns a source map on the load hook which is not being read at all. Will see what I can do about it!

@charlag
Copy link
Contributor Author

charlag commented Jan 7, 2022

@PepsRyuu awesome, thanks for checking it!

@PepsRyuu
Copy link
Owner

PepsRyuu commented Jan 7, 2022

Fixed in 0.18.7

@PepsRyuu PepsRyuu closed this as completed Jan 7, 2022
@charlag
Copy link
Contributor Author

charlag commented Jan 7, 2022

@PepsRyuu wow that was fast, will check on Monday, thank you again!

@PepsRyuu
Copy link
Owner

PepsRyuu commented Jan 7, 2022

😁

If there's any issues let me know!

charlag added a commit to tutao/tutanota that referenced this issue Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants