fix(types): complete Phase 1 cleanup of types-hierarchy-refactor#420
Merged
Merged
Conversation
Contributor
✅ Visual Regression Test ResultsStatus: ✅ All visual tests passed! All screenshots match the baseline. No visual regressions detected! 🎉 |
Contributor
⚡ Performance Benchmark Results✅ Build Time Benchmarks: PASSED✅ Bundle Size Benchmarks: PASSED❌ Runtime Vitals Benchmarks: FAILED📝 Note: Detailed results are available in the job logs. 🎯 Performance Budgets:
Updated: 2026-05-15T17:06:28.720Z |
Contributor
♿ Accessibility Test ResultsOverall Status: ✅ 0/0 tests passed 🦮 WCAG 2.1 AA ComplianceNo WCAG test results available ⌨️ Keyboard NavigationNo keyboard navigation test results available 📊 Detailed ReportDownload the full HTML accessibility report from the workflow artifacts for:
🔍 Testing ChecklistOur accessibility tests verify:
Powered by @axe-core/playwright and Playwright |
Three items from Phase 1 of the types-hierarchy-refactor that were missed when PR #408 merged: 1. collections/src/types.ts zombie removed The original CollectionProvider interface definitions were left in place after being moved to @stackwright/types. types.ts is now a re-export shim; file-collection-provider.ts imports directly from @stackwright/types. 2. HookHandler forwarded through hooks-registry and scaffold-core HookHandler was canonical in @stackwright/types and re-exported by hooks-registry/src/hooks.ts but not forwarded through index.ts, making it unavailable via public import paths. Both packages now re-export it alongside the other scaffold hook types. 3. generate-agent-docs extended with interface contracts table (step 8) A new auto-generated section in both AGENTS.md files documents the TypeScript interface contracts from @stackwright/types: CollectionProvider, CollectionEntry, CollectionListOptions, CollectionListResult, ScaffoldHookContext, ScaffoldHook, HookHandler, ScaffoldHookType. Delimited by stackwright:interface-table:start/end markers, updated by the existing generate-agent-docs command alongside the content-type-table. Changesets: collections-types-cleanup (patch), hookhandler-reexport (patch for hooks-registry + scaffold-core), generate-agent-docs-interfaces (patch for cli).
perasperaactual
force-pushed
the
fix/types-hierarchy-refactor-phase1-cleanup
branch
from
5bb4603 to
18f44a6
Compare
Contributor
✅ Visual Regression Test ResultsStatus: ✅ All visual tests passed! All screenshots match the baseline. No visual regressions detected! 🎉 |
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three items from Phase 1 of the types-hierarchy-refactor (#408) that were identified as incomplete during a post-merge audit.
Changes
1.
collections/src/types.tszombie removedThe original
CollectionProviderinterface definitions were left in place after being moved to@stackwright/types.types.tsis now a re-export shim so any downstream imports remain backward-compatible.file-collection-provider.tsnow imports directly from@stackwright/types.2.
HookHandlerforwarded throughhooks-registryandscaffold-coreHookHandlerwas canonical in@stackwright/typesand re-exported byhooks-registry/src/hooks.tsbut not forwarded throughindex.ts, makingimport type { HookHandler } from '@stackwright/hooks-registry'fail silently. Both@stackwright/hooks-registryand@stackwright/scaffold-corenow re-export it alongside the other scaffold hook types.3.
generate-agent-docsextended with interface contracts table (Phase 1 step 8)A new auto-generated section in both
AGENTS.mdfiles documents the TypeScript interface contracts from@stackwright/types. The section is delimited by<!-- stackwright:interface-table:start/end -->markers and updated bypnpm stackwright -- generate-agent-docsalongside the existing content-type-table.Testing
pnpm test— 864/864 passingpnpm build— all 15 packages cleanpnpm stackwright -- generate-agent-docs— both AGENTS.md files confirmed in syncChangesets
collections-types-cleanup— patch for@stackwright/collectionshookhandler-reexport— patch for@stackwright/hooks-registry,@stackwright/scaffold-coregenerate-agent-docs-interfaces— patch for@stackwright/cli