New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives each input group a class that can be styled #63

Merged
merged 1 commit into from Nov 8, 2016

Conversation

Projects
None yet
2 participants
@AndyGaskell
Contributor

AndyGaskell commented Nov 7, 2016

Hi Christian

This is a minor change that I've been making. it is just adding a class, based on the field id, to each control group. This means each one has a class that can be styled in css. I've found this really useful for front end editing.

In normal use, it wont really change anything, but having the class there provides much greater flexibility in styling.

As well as styling, it can be very useful for jQuery UI logic. We often have use cases where some fields get shown of hidden, depending on the value of other fields. If each field has a unique class it means they can be shown of hidden using that as a jQuery selector.

I hope this sounds ok, let me know what you think.

Thanks
Andy

Gives each input group a class that can be styled
Hi Christian

This is a minor change that I've been making.  it is just adding a class, based on the field id, to each control group.  This means each one has a class that can be styled in css.  I've found this really useful for front end editing.

In normal use, it wont really change anything, but having the class there provides much greater flexibility in styling.

As well as styling, it can be very useful for jQuery UI logic.  We often have use cases where some fields get shown of hidden, depending on the value of other fields.  If each field has a unique class it means they can be shown of hidden using that as a jQuery selector.

I hope this sounds ok, let me know what you think.

Thanks
Andy
@graredcr

This comment has been minimized.

Show comment
Hide comment
@graredcr

graredcr Nov 7, 2016

Contributor

Hi, today I will make a look and marge

Contributor

graredcr commented Nov 7, 2016

Hi, today I will make a look and marge

@AndyGaskell

This comment has been minimized.

Show comment
Hide comment
@AndyGaskell

AndyGaskell Nov 7, 2016

Contributor

Thanks Christian :)

Contributor

AndyGaskell commented Nov 7, 2016

Thanks Christian :)

@graredcr graredcr merged commit 6c4038e into Percha:master Nov 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment