From f3c1965896d1a5ba24c225631d73b4d3f5a440f4 Mon Sep 17 00:00:00 2001 From: Tim Vaillancourt Date: Sun, 18 Jun 2017 20:43:46 +0200 Subject: [PATCH] Fix disabling of oplog tailer --- mongodb_consistent_backup/Main.py | 2 +- mongodb_consistent_backup/Oplog/Tailer/Tailer.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/mongodb_consistent_backup/Main.py b/mongodb_consistent_backup/Main.py index 66e9fa56..a36424b1 100644 --- a/mongodb_consistent_backup/Main.py +++ b/mongodb_consistent_backup/Main.py @@ -414,7 +414,7 @@ def run(self): self.db.close() # resolve/merge tailed oplog into mongodump oplog.bson to a consistent point for all shards - if self.backup.task.lower() == "mongodump" and self.oplogtailer: + if self.backup.task.lower() == "mongodump" and self.oplogtailer.enabled(): self.resolver = Resolver( self.manager, self.config, diff --git a/mongodb_consistent_backup/Oplog/Tailer/Tailer.py b/mongodb_consistent_backup/Oplog/Tailer/Tailer.py index 18164b26..681aed48 100644 --- a/mongodb_consistent_backup/Oplog/Tailer/Tailer.py +++ b/mongodb_consistent_backup/Oplog/Tailer/Tailer.py @@ -30,7 +30,9 @@ def __init__(self, manager, config, timer, base_dir, backup_dir, replsets, backu self._summary = {} def enabled(self): - if self._enabled.lower().strip() != 'false': + if isinstance(self._enabled, bool): + return self._enabled + elif isinstance(self._enabled, str) and self._enabled.strip().lower() != 'false': return True return False