Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-2691 Allow environment var to change rpmbuild docker image/repo #60

Merged

Conversation

Projects
None yet
4 participants
@israelshirk
Copy link
Contributor

commented Jun 29, 2018

Just pulls from$RPMBUILD_DOCKER_IMAGE in vars if present.

@JNKPercona

This comment has been minimized.

Copy link
Collaborator

commented Jun 29, 2018

@delgod delgod requested review from delgod and rnovikovP Jun 29, 2018

@delgod

delgod approved these changes Jun 29, 2018

Copy link
Member

left a comment

thanks 👍

@rnovikovP rnovikovP changed the title Allow environment var to change rpmbuild docker image/repo PMM-2691 Allow environment var to change rpmbuild docker image/repo Jun 29, 2018

@rnovikovP rnovikovP self-assigned this Jun 29, 2018

@rnovikovP rnovikovP added the 1.13.0 label Jun 29, 2018

@rnovikovP

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2018

Thanks, @israelshirk !
We'll merge this next week. Right now we have some code freeze period.
I'm curious, what is your use case for this change? how you'll use this project?

@israelshirk

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2018

Thanks guys!

@rnovikovP As far as the tagging specifically I'm in a PCI environment, so doing our own trusted builds behind the firewall from known good sources and keeping that list short is a big win; we also duplicate out to public docker and Travis CI where we can because... open source FTW! Technically we could just use the same tag and cache it internally but that's a bit dirty.

On a higher level on what we're doing with the project, we're splitting out PMM into a standard set of k8s pods to go along with our current work on XTRAdb + k8s here - https://github.com/nlp-secure/percona-docker - in the end, we'd like to just have just about the entire system be fire and forget to get a nice multi-zonal HA system on GCE/AWS/multi-AZ solutions, with minimal variance from you guys' upstream work. We're also currently running Consul, XTRAdb, and Prometheus on our monitoring and production clusters (looking at each other), so deduplicating the extra copies would be ideal.

@rnovikovP rnovikovP merged commit 6f5536e into Percona-Lab:master Jul 3, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@israelshirk israelshirk deleted the nlp-secure:feature/variable-rpmbuilder-repo branch Jul 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.