New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source jars are part of binary distribution #192

Closed
marvec opened this Issue Mar 23, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@marvec
Member

marvec commented Mar 23, 2015

They definitely should not be there, plus it leads to malfunction of the startup script in random cases.

@marvec marvec added the bug label Mar 23, 2015

@marvec marvec self-assigned this Mar 23, 2015

@marvec marvec added this to the Release 5.0 milestone Mar 23, 2015

@pmacik pmacik modified the milestones: Release 4.1, Release 5.0 Mar 23, 2015

@pmacik

This comment has been minimized.

Show comment
Hide comment
@pmacik

pmacik Mar 23, 2015

Member

PerfCake JARs in lib directory:

~/perfcake-4.0 $ ls lib | grep perfcake
perfcake-4.0.jar
perfcake-4.0-sources.jar

Script output:

~/perfcake-4.0 $ ./bin/perfcake.sh 
no main manifest attribute, in /home/pmacik/perfcake-4.0/lib/perfcake-4.0-sources.jar
Member

pmacik commented Mar 23, 2015

PerfCake JARs in lib directory:

~/perfcake-4.0 $ ls lib | grep perfcake
perfcake-4.0.jar
perfcake-4.0-sources.jar

Script output:

~/perfcake-4.0 $ ./bin/perfcake.sh 
no main manifest attribute, in /home/pmacik/perfcake-4.0/lib/perfcake-4.0-sources.jar
@pmacik

This comment has been minimized.

Show comment
Hide comment
@pmacik

pmacik Mar 23, 2015

Member

Assembly plugin configuration update should suffice to exclude the "sources" JAR.

Member

pmacik commented Mar 23, 2015

Assembly plugin configuration update should suffice to exclude the "sources" JAR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment