Fix the tracking of violation lines #702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I couldn't find an issue relating to this.)
The code that tries to discover on which line a violation occurred uses a regex that accidentally treats multiple newlines as a single line.
Using a policy that tries to detect errors in multiple lines, such as Perl::Critic::Policy::CodeLayout::ProhibitHashBarewords:
Use of uninitialized value $min_width in numeric gt (>)
at /usr/local/share/perl/5.18.2/String/Format.pm line 51.
Use of uninitialized value $replacement in concatenation (.) or string
at /usr/local/share/perl/5.18.2/String/Format.pm line 67.
The solution is to remove '\s*' and instead make sure we split with a negative third argument in order to preserve the number of consecutive empty lines we encounter.