Repository navigation
Stop improper violation for lexical subroutines in Subroutines::ProhibitBuiltinHomonyms - #973
Merged
Merged
Conversation
As of B::Keyword 1.23, `import` is moved from @functions to @BarewordsExtra.
Contributor
Author
|
Since Perl-Critic/PPI#260 is fixed, we can treat names of lexical subroutines appropriately once we update PPI. |
Contributor
Author
|
Oops! Tests on Perl 5.10 and 5.8 are failed because URI-cpan-1.008 requires Perl 5.12. https://metacpan.org/release/RJBS/URI-cpan-1.008/source/Makefile.PL#L17 |
Member
|
What do we need to do to get this something I can merge? I know we'll need to remove the PPI workarounds. How does URI::cpan fit in to this? |
Member
|
This tested just fine on a test branch with no conflicts, so I've squashed and merged it here. Thank you. |
petdance
added a commit
that referenced
this pull request
Dec 12, 2022
Member
|
All merged and ready for next release: 0edb07d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subroutines::ProhibitBuiltinHomonymspolicy incorrectly emits violation for lexical subroutine whose name is not same as builtin functions. Running the following code:Actual result: a violation
Subroutine name is a homonym for builtin keyword sub at line 1, column 1. See page 177 of PBP.is printed.Expected result: no violation is printed.
Fixes #955.
Fixes #546.