New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure #4

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@jmaslak

jmaslak commented Aug 31, 2016

The git repo code would not pass make test. I've fixed that.

The code was stripping -TRIAL (but not -TRIAL3) from the version number - I removed the stripping action, thus allowing it to pass path.t. However, that made it fail ext.t instead (which expected -TRIAL.* to be removed). Looking at the version on CPAN, -TRIAL was present there and not stripped, and the tests that failed after the change back were not present in ext.t. I also think that the -TRIAL indicator could be significant as part of the version, so I think this is the right fix.

However, if it's not, and it should be stripped, let me know and I'll be glad to submit a PR with that in mind instead.

FYI this submission is part of the CPAN Pull Request Challenge - I was assigned your module for August.

@jmaslak

This comment has been minimized.

Show comment
Hide comment
@jmaslak

jmaslak Aug 31, 2016

Note that my change does disagree with PR #2 - they felt that -TRIAL should be removed (and likely that is where this bug got introduced for the test failure). I have a different patch that is compatible with PR#2 but fixes the test failures if that's preferred.

jmaslak commented Aug 31, 2016

Note that my change does disagree with PR #2 - they felt that -TRIAL should be removed (and likely that is where this bug got introduced for the test failure). I have a different patch that is compatible with PR#2 but fixes the test failures if that's preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment