New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to say "OS not supported" #298

Open
neilb opened this Issue May 12, 2017 · 7 comments

Comments

Projects
None yet
6 participants
@neilb
Contributor

neilb commented May 12, 2017

Last week I had to, not for the first time, try and remember / find the special string you exit from Makefile.PL with if the OS isn't supported. Ie this:

die "No support for OS\n" if $^O eq 'MSWin32';

At the very least this needs to documented somewhere, but more than that, how about EUMM providing one or more convenience functions, so people don't have to embed that string?a

This could be something like:

os_not_supported('MSWin32');
os_restriction('MSWin32');

Haven't really thought much about the interface -- I wanted to raise the ticket before I forgot about this.

I guess it would be in a separate package, so Build.PL could use it as well...

@bingos

This comment has been minimized.

Show comment
Hide comment
@bingos

bingos May 12, 2017

Member

Implemented as os_unsupported() with commit fcdaaac

Member

bingos commented May 12, 2017

Implemented as os_unsupported() with commit fcdaaac

@Leont

This comment has been minimized.

Show comment
Hide comment
@Leont

Leont May 12, 2017

Member

Implemented as os_unsupported() with commit fcdaaac

It really should document "supported since 7.26"

Member

Leont commented May 12, 2017

Implemented as os_unsupported() with commit fcdaaac

It really should document "supported since 7.26"

@bingos

This comment has been minimized.

Show comment
Hide comment
@bingos

bingos May 12, 2017

Member

Done

Member

bingos commented May 12, 2017

Done

@ap

This comment has been minimized.

Show comment
Hide comment
@ap

ap Jun 3, 2017

Calling that function from Makefile.PL requires configure_requires support from the underlying toolchain. Is that worth it for being able to spell die "OS unsupported\n" as os_unsupported()? 😐

ap commented Jun 3, 2017

Calling that function from Makefile.PL requires configure_requires support from the underlying toolchain. Is that worth it for being able to spell die "OS unsupported\n" as os_unsupported()? 😐

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Jun 3, 2017

Member

Of course not. But in 20 years, when everyone has this version of EUMM in core, we'll sure be happy we have it. 👯‍♂️

(sarcasm)

Member

karenetheridge commented Jun 3, 2017

Of course not. But in 20 years, when everyone has this version of EUMM in core, we'll sure be happy we have it. 👯‍♂️

(sarcasm)

@ap

This comment has been minimized.

Show comment
Hide comment
@ap

ap Jun 3, 2017

Fear not: the clock started 6 years ago when 5.14 shipped with working configure_requires, so it’s only 14 years from now. 😊

ap commented Jun 3, 2017

Fear not: the clock started 6 years ago when 5.14 shipped with working configure_requires, so it’s only 14 years from now. 😊

@mohawk2

This comment has been minimized.

Show comment
Hide comment
@mohawk2

mohawk2 Dec 4, 2017

Member

Can this issue be closed now?

Member

mohawk2 commented Dec 4, 2017

Can this issue be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment