New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on missing prereqs for *_REQUIRES, issue #194. #227

Merged
merged 2 commits into from Aug 19, 2015

Conversation

Projects
None yet
4 participants
@thrig

thrig commented Jul 14, 2015

Dunno if anything else need be done, or ramifications of such.

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Jul 14, 2015

Member

Awesome :)

Member

karenetheridge commented Jul 14, 2015

Awesome :)

@mohawk2

This comment has been minimized.

Show comment
Hide comment
@mohawk2

mohawk2 Jul 18, 2015

Member

Looks like a worth addition! Now if only there were a test included... :-)

Member

mohawk2 commented Jul 18, 2015

Looks like a worth addition! Now if only there were a test included... :-)

@thrig

This comment has been minimized.

Show comment
Hide comment
@thrig

thrig Aug 18, 2015

So these just check that C_R and T_R emit messages, and not the full monty of "" version number checks and such, but in the code it looks like everything gets shoved into that one loop... (adding what _REQUIRES failed to the message would be more work).

thrig commented Aug 18, 2015

So these just check that C_R and T_R emit messages, and not the full monty of "" version number checks and such, but in the code it looks like everything gets shoved into that one loop... (adding what _REQUIRES failed to the message would be more work).

bingos added a commit that referenced this pull request Aug 19, 2015

Merge pull request #227 from thrig/master
Warn on missing prereqs for *_REQUIRES, issue #194.

@bingos bingos merged commit b1dfa30 into Perl-Toolchain-Gang:master Aug 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment