Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

patched the warning I reporeted earlier in #22 #23

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

szabgab commented Dec 5, 2011

No description provided.

Member

mohawk2 commented Jul 22, 2014

Is this issue still relevant post Lancaster Consensus?

Member

karenetheridge commented Jul 22, 2014

This needs to be tested on 5.6 before it can be considered safe to merge. Travis only tested on 5.10+.

Contributor

rurban commented Jul 22, 2014

This does of course not work without PerlIO (i.e. 5.6) and even produces a nice crash:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7b1a9f1 in Perl_vmess (pat=0x7ffff7bbc55a "Unknown open() mode '%.*s'", args=0x7fffffffe058) at util.c:1529
1529        if (PL_last_in_gv && GvGP(PL_last_in_gv) && GvIO(PL_last_in_gv) && IoLINES(GvIOp(PL_last_in_gv))) {
(gdb) bt
#0  0x00007ffff7b1a9f1 in Perl_vmess (pat=0x7ffff7bbc55a "Unknown open() mode '%.*s'", args=0x7fffffffe058) at util.c:1529
#1  0x00007ffff7b1b449 in Perl_vcroak (pat=0x7ffff7bbc55a "Unknown open() mode '%.*s'", args=0x7fffffffe058) at util.c:1657
#2  0x00007ffff7b1bcf2 in Perl_croak (pat=0x7ffff7bbc55a "Unknown open() mode '%.*s'") at util.c:1761
#3  0x00007ffff7b942b8 in Perl_do_open9 (gv=0x10c8bb0, name=0x112ea50 "MakeMaker.tmp", len=13, as_raw=0, rawmode=0, 
    rawperm=0, supplied_fp=0x0, svs=0x81bd00, num_svs=1) at doio.c:208
#4  0x00007ffff7b7d1c4 in Perl_pp_open () at pp_sys.c:528
Member

mohawk2 commented Jul 23, 2014

@rurban suggests that what would protect from 5.6 failures is:

my $layer = ($] < 5.008 || !$Config{useperlio}) ? "" : ":utf8";

If @szabgab doesn't want to update his PR, and if someone is willing to merge this I will followup with a PR with that update. @szabgab?

Contributor

szabgab commented Jul 23, 2014

I am off this issue.

Member

mohawk2 commented Jul 29, 2014

@szabgab, your code has been taken forward with @rurban's 5.6-preserving change into PR #109. For tidiness (and not being pestered with updates!), you could close this?

Contributor

szabgab commented Jul 29, 2014

thanks

@szabgab szabgab closed this Jul 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment