Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

You cannot trust that a boolean function will return 1.

  • Loading branch information...
commit fce7c9ccdf619f70cbe9fb957b626cd420527102 1 parent 8b7add7
@schwern schwern authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/Module/Build/Base.pm
View
2  lib/Module/Build/Base.pm
@@ -38,7 +38,7 @@ sub new {
$self->check_manifest;
$self->auto_require;
- if ( $self->check_prereq + $self->check_autofeatures != 2) {
+ if ( !$self->check_prereq || !$self->check_autofeatures ) {
$self->log_warn(<<EOF);
ERRORS/WARNINGS FOUND IN PREREQUISITES. You may wish to install the versions

3 comments on commit fce7c9c

@Leont
Owner

Both have the side-effect of outputting stuff to the user. Now that output may be incomplete if the dist is missing prerequisites.

@schwern
Owner

Yep, I just fixed it. 8acbab6

The side effects are evil all the way down. I was particularly disheartened to see that they check for the word disabled in the formatted output.

@dagolden
Owner

There is an insane amount of stuff like that in Module::Build. Things that seem simple refactoring/cleanup wind up having unexpected consequences.

Please sign in to comment.
Something went wrong with that request. Please try again.