New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second try #55

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@ambs
Contributor

ambs commented Aug 22, 2016

No description provided.

@ambs ambs referenced this pull request Aug 22, 2016

Closed

first try fixing utf8 issues #52

@Leont

This comment has been minimized.

Show comment
Hide comment
@Leont

Leont Aug 22, 2016

Member

The if utf8::is_utf8 has to go. Please forget that that function exists, pretty much all uses of it are wrong.

Member

Leont commented Aug 22, 2016

The if utf8::is_utf8 has to go. Please forget that that function exists, pretty much all uses of it are wrong.

Show outdated Hide outdated lib/Module/Install.pm

Leont and others added some commits Aug 23, 2016

@ambs

This comment has been minimized.

Show comment
Hide comment
@ambs

ambs Aug 23, 2016

Contributor

Thanks, @Leont, for your changes.
I fixed now test 20 to use utf8 as well.
If all looks good, can we merge this one?

Contributor

ambs commented Aug 23, 2016

Thanks, @Leont, for your changes.
I fixed now test 20 to use utf8 as well.
If all looks good, can we merge this one?

@mattias-p

This comment has been minimized.

Show comment
Hide comment
@mattias-p

mattias-p Oct 3, 2017

Is there anything happening for this PR? Any chance it gets merged?

For what it's worth I successfully tested 2f76d53. Unit tests pass and META.yml gets written in UTF-8 (I've got an author with U+00E4 characters in Makefile.PL).

mattias-p commented Oct 3, 2017

Is there anything happening for this PR? Any chance it gets merged?

For what it's worth I successfully tested 2f76d53. Unit tests pass and META.yml gets written in UTF-8 (I've got an author with U+00E4 characters in Makefile.PL).

@karenetheridge karenetheridge self-assigned this Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment