New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in CONTRIBUTING mentioned in rt94900 #9

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mcmillhj

mcmillhj commented Apr 28, 2015

No description provided.

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Apr 28, 2015

Member

This file is auto-generated, so it would be preferable to fix it at its origin - which would be in Dist::Zilla::PluginBundle::DAGOLDEN.

...I think. :) @dagolden do you manually copy this file from a template?

(I see some other typos in that file too.)

Member

karenetheridge commented Apr 28, 2015

This file is auto-generated, so it would be preferable to fix it at its origin - which would be in Dist::Zilla::PluginBundle::DAGOLDEN.

...I think. :) @dagolden do you manually copy this file from a template?

(I see some other typos in that file too.)

@mcmillhj

This comment has been minimized.

Show comment
Hide comment
@mcmillhj

mcmillhj Apr 28, 2015

Oh, my mistake. Ironically, the line I "corrected" in the CONTRIBUTING file explains this. I will close this PR. The build seems to have failed for a separate reason.

mcmillhj commented Apr 28, 2015

Oh, my mistake. Ironically, the line I "corrected" in the CONTRIBUTING file explains this. I will close this PR. The build seems to have failed for a separate reason.

@mcmillhj mcmillhj closed this Apr 28, 2015

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Apr 28, 2015

It's actually not generated, but it's a hint that the repo is out of date with respect to my current build practices. I'll fix that up shortly (including the build problems).

ghost commented Apr 28, 2015

It's actually not generated, but it's a hint that the repo is out of date with respect to my current build practices. I'll fix that up shortly (including the build problems).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment