tweak to ade heuristic scanning #25

Closed
kevindawson opened this Issue Feb 24, 2014 · 3 comments

Projects

None yet

2 participants

@kevindawson
Member
BEGIN {
    local $@;
-    if ( eval { require Scalar::Util }
-      && $Scalar::Util::VERSION
-      && eval($Scalar::Util::VERSION) >= 1.18
-    ) {
+   if ( eval { require Scalar::Util; Scalar::Util->VERSION(1.18) } ) {
        *refaddr = *Scalar::Util::refaddr;
    }
    else {
@karenetheridge
Member

What impact would this change have? That is, what heuristic scanners are you looking at, and what was the output before, and would it be afterwards?

@kevindawson
Member

On 25/02/14 00:41, Karen Etheridge wrote:

What impact would this change have? That is, what heuristic scanners
are you looking at, and what was the output before, and would it be
afterwards?


Reply to this email directly or view it on GitHub
#25 (comment).

ether

see: https://github.com/rjbs/Perl-PrereqScanner/pull/34/files

t/scanner-eval.t

line 268

regards
kevin

@karenetheridge
Member

Agreed, this is nicer! I'll apply it!

@karenetheridge karenetheridge referenced this issue in Perl-Toolchain-Gang/CPAN-Meta-YAML Mar 13, 2015
Closed

some tests file leave stuff under /tmp #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment