From c8a2d99909f8427eef6849dad22ea598acd47390 Mon Sep 17 00:00:00 2001 From: Karl Williamson Date: Mon, 12 Apr 2021 05:10:37 -0600 Subject: [PATCH] t/loc_tools.pl: Don't allow commas in locale names This was a problem in some buggy Windows versions. This addition keeps locales with this bug from being tested. --- t/loc_tools.pl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/t/loc_tools.pl b/t/loc_tools.pl index 0fcffdcd48c0..3017c90fefb9 100644 --- a/t/loc_tools.pl +++ b/t/loc_tools.pl @@ -187,6 +187,11 @@ ($$$$) return; } + # Commas in locale names are bad in Windows, and there is a bug in + # some versions where setlocale() turns a legal input locale name into + # an illegal return value, which it can't later parse. + return if $result =~ /,/; + return unless $plays_well || $allow_incompatible; }