From d4b5775530c18a6f4dbe41d7875692ae17742cd8 Mon Sep 17 00:00:00 2001
From: Karl Williamson <khw@cpan.org>
Date: Fri, 19 May 2023 15:59:42 -0600
Subject: [PATCH] Time-Piece: notes to myself

---
 cpan/Time-Piece/Piece.xs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/cpan/Time-Piece/Piece.xs b/cpan/Time-Piece/Piece.xs
index b487026f5900..78f6ea133022 100644
--- a/cpan/Time-Piece/Piece.xs
+++ b/cpan/Time-Piece/Piece.xs
@@ -47,6 +47,8 @@
 #  define PERL_VERSION_GE(j,n,p)  0
 #endif
 
+/* XXX bunch of other locks need, tzset putenv, getenv; haven't looked */
+
 #ifdef WIN32
 
 /*
@@ -119,6 +121,7 @@
 #undef malloc
 #undef free
 
+/* Should call the one in Posix:: */
 static void
 fix_win32_tzenv(void)
 {
@@ -824,6 +827,7 @@ label:
 				return 0;
 
 			len = (c == 'Y') ? 4 : 2;
+                        /* XXX note this is a bug is isdigit, subtracting '0' because could be another set of 10. */
 			for (i = 0; len && *buf != 0 && isDIGIT_LC((unsigned char)*buf); buf++) {
 				i *= 10;
 				i += *buf - '0';