Fw: PATCH fixes for File::Find

[p5pRT]

Migrated from rt.perl.org#71710 (status was 'resolved')

Searchable as RT71710$

[p5pRT]

From alex.davies@talktalk.net

Created by alex@AMELIE

Resubmitting patches to perlbug as per Jesse's request.

From​: <alex.davies@​talktalk.net>
To​: <perl5-porters@​perl.org>
Sent​: Tuesday, December 15, 2009 9​:51 PM
Subject​: PATCH fixes for File​::Find

Hey All,

Please find attached patches for File​::Find and its test file.

The changes ensure that paths passed to File​::Find​::find() on Win32
which have a trailing *back*slash are neatly handled. That is, the
change ensures paths such as c​:\dir\/file are no longer generated.

Cheers, alex.

Perl Info

Flags:
    category=core
    severity=low

Site configuration information for perl 5.10.0:

Configured by adam at Mon Aug 11 04:41:10 2008.

Summary of my perl5 (revision 5 version 10 subversion 0) configuration:
  Platform:
    osname=MSWin32, osvers=5.1, archname=MSWin32-x86-multi-thread
    uname=''
    config_args='undef'
    hint=recommended, useposix=true, d_sigaction=undef
    useithreads=define, usemultiplicity=define
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='gcc', ccflags 
=' -s -O2 -DWIN32 -DHAVE_DES_FCRYPT  -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -fno-strict-aliasing 
 -DPERL_MSVCRT_READFIX',
    optimize='-s -O2',
    cppflags='-DWIN32'
    ccversion='', gccversion='3.4.5', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='long long', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='g++', ldflags ='-s -L"C:\strawberry\perl\lib\CORE" -L"C:\strawberry\c\lib"'
    libpth=C:\strawberry\c\lib
    libs= -lmsvcrt -lmoldname -lkernel32 -luser32 -lgdi32 -lwinspool -lcomdlg32 -ladvapi32 -lshell32 
 -lole32 -loleaut32 -lnetapi32 -luuid -lws2_32 -lmpr -lwinmm -lversion -lodbc32 -lodbccp32
    perllibs= -lmsvcrt -lmoldname -lkernel32 -luser32 -lgdi32 -lwinspool -lcomdlg32 -ladvapi32 -lshell32 
 -lole32 -loleaut32 -lnetapi32 -luuid -lws2_32 -lmpr -lwinmm -lversion -lodbc32 -lodbccp32
    libc=-lmsvcrt, so=dll, useshrplib=true, libperl=libperl510.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags='-mdll -s -L"C:\strawberry\perl\lib\CORE" -L"C:\strawberry\c\lib"'

Locally applied patches:



@INC for perl 5.10.0:
    C:/strawberry/perl/lib
    C:/strawberry/perl/site/lib
    .


Environment for perl 5.10.0:
    HOME=C:\alex
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=C:\Program 
Files\Ruby-185-21\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\alex\bin;C:\Program 
Files\Microsoft SDK\Bin\.;C:\Program Files\Microsoft SDK\Bin\WinNT\.;C:\Program 
Files\Tcl-8.5.0\bin;C:\PerlAPPv9\bin;C:\Program 
Files\QuickTime\QTSystem\;C:\strawberry\c\bin;C:\strawberry\perl\bin;C:\Program 
Files\Git\cmd;C:\Program Files\Microsoft Visual Studio\VC98\Bin;C:\Program Files\Microsoft 
SDK\Bin\.;C:\Program Files\Microsoft SDK\Bin\WinNT;C:\cygwin\bin
    PERL_BADLANG (unset)
    SHELL (unset)

[p5pRT]

From alex.davies@talktalk.net

Find.pm-patch

[p5pRT]

From alex.davies@talktalk.net

find.t-patch

[p5pRT]

From @cpansprout

On Tue Dec 29 07​:17​:28 2009, alex.davies@​talktalk.net wrote​:

Please find attached patches for File​::Find and its test file.

The changes ensure that paths passed to File​::Find​::find() on Win32
which have a trailing *back*slash are neatly handled. That is, the
change ensures paths such as c​:\dir\/file are no longer generated.

Thank you. I have applied these as
a0b245d. I took the liberty of changing
capturing parentheses to (?​:...) to avoid triggering the pre-match copy
unnecessarily.

[p5pRT]

The RT System itself - Status changed from 'new' to 'open'

[p5pRT]

@cpansprout - Status changed from 'open' to 'resolved'

[p5pRT]

From @cpansprout

On Thu Sep 23 17​:25​:34 2010, sprout wrote​:

On Tue Dec 29 07​:17​:28 2009, alex.davies@​talktalk.net wrote​:

Please find attached patches for File​::Find and its test file.

The changes ensure that paths passed to File​::Find​::find() on Win32
which have a trailing *back*slash are neatly handled. That is, the
change ensures paths such as c​:\dir\/file are no longer generated.

Thank you. I have applied these as
a0b245d. I took the liberty of changing
capturing parentheses to (?​:...) to avoid triggering the pre-match copy
unnecessarily.

I messed up the commit and only applied half the File.pm patch. The
second half has been applied as b242981.