Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fw: PATCH fixes for File::Find #10037

Closed
p5pRT opened this issue Dec 29, 2009 · 7 comments
Closed

Fw: PATCH fixes for File::Find #10037

p5pRT opened this issue Dec 29, 2009 · 7 comments

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Dec 29, 2009

Migrated from rt.perl.org#71710 (status was 'resolved')

Searchable as RT71710$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Dec 29, 2009

From alex.davies@talktalk.net

Created by alex@AMELIE

Resubmitting patches to perlbug as per Jesse's request.

From​: <alex.davies@​talktalk.net>
To​: <perl5-porters@​perl.org>
Sent​: Tuesday, December 15, 2009 9​:51 PM
Subject​: PATCH fixes for File​::Find

Hey All,

Please find attached patches for File​::Find and its test file.

The changes ensure that paths passed to File​::Find​::find() on Win32
which have a trailing *back*slash are neatly handled. That is, the
change ensures paths such as c​:\dir\/file are no longer generated.

Cheers, alex.

Perl Info

Flags:
    category=core
    severity=low

Site configuration information for perl 5.10.0:

Configured by adam at Mon Aug 11 04:41:10 2008.

Summary of my perl5 (revision 5 version 10 subversion 0) configuration:
  Platform:
    osname=MSWin32, osvers=5.1, archname=MSWin32-x86-multi-thread
    uname=''
    config_args='undef'
    hint=recommended, useposix=true, d_sigaction=undef
    useithreads=define, usemultiplicity=define
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='gcc', ccflags 
=' -s -O2 -DWIN32 -DHAVE_DES_FCRYPT  -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -fno-strict-aliasing 
 -DPERL_MSVCRT_READFIX',
    optimize='-s -O2',
    cppflags='-DWIN32'
    ccversion='', gccversion='3.4.5', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='long long', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='g++', ldflags ='-s -L"C:\strawberry\perl\lib\CORE" -L"C:\strawberry\c\lib"'
    libpth=C:\strawberry\c\lib
    libs= -lmsvcrt -lmoldname -lkernel32 -luser32 -lgdi32 -lwinspool -lcomdlg32 -ladvapi32 -lshell32 
 -lole32 -loleaut32 -lnetapi32 -luuid -lws2_32 -lmpr -lwinmm -lversion -lodbc32 -lodbccp32
    perllibs= -lmsvcrt -lmoldname -lkernel32 -luser32 -lgdi32 -lwinspool -lcomdlg32 -ladvapi32 -lshell32 
 -lole32 -loleaut32 -lnetapi32 -luuid -lws2_32 -lmpr -lwinmm -lversion -lodbc32 -lodbccp32
    libc=-lmsvcrt, so=dll, useshrplib=true, libperl=libperl510.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags='-mdll -s -L"C:\strawberry\perl\lib\CORE" -L"C:\strawberry\c\lib"'

Locally applied patches:



@INC for perl 5.10.0:
    C:/strawberry/perl/lib
    C:/strawberry/perl/site/lib
    .


Environment for perl 5.10.0:
    HOME=C:\alex
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=C:\Program 
Files\Ruby-185-21\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\alex\bin;C:\Program 
Files\Microsoft SDK\Bin\.;C:\Program Files\Microsoft SDK\Bin\WinNT\.;C:\Program 
Files\Tcl-8.5.0\bin;C:\PerlAPPv9\bin;C:\Program 
Files\QuickTime\QTSystem\;C:\strawberry\c\bin;C:\strawberry\perl\bin;C:\Program 
Files\Git\cmd;C:\Program Files\Microsoft Visual Studio\VC98\Bin;C:\Program Files\Microsoft 
SDK\Bin\.;C:\Program Files\Microsoft SDK\Bin\WinNT;C:\cygwin\bin
    PERL_BADLANG (unset)
    SHELL (unset)

Loading

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Dec 29, 2009

Loading

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Dec 29, 2009

Loading

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Sep 24, 2010

From @cpansprout

On Tue Dec 29 07​:17​:28 2009, alex.davies@​talktalk.net wrote​:

Please find attached patches for File​::Find and its test file.

The changes ensure that paths passed to File​::Find​::find() on Win32
which have a trailing *back*slash are neatly handled. That is, the
change ensures paths such as c​:\dir\/file are no longer generated.

Thank you. I have applied these as
a0b245d. I took the liberty of changing
capturing parentheses to (?​:...) to avoid triggering the pre-match copy
unnecessarily.

Loading

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Sep 24, 2010

The RT System itself - Status changed from 'new' to 'open'

Loading

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Sep 24, 2010

@cpansprout - Status changed from 'open' to 'resolved'

Loading

@p5pRT p5pRT closed this Sep 24, 2010
@p5pRT
Copy link
Author

@p5pRT p5pRT commented Sep 24, 2010

From @cpansprout

On Thu Sep 23 17​:25​:34 2010, sprout wrote​:

On Tue Dec 29 07​:17​:28 2009, alex.davies@​talktalk.net wrote​:

Please find attached patches for File​::Find and its test file.

The changes ensure that paths passed to File​::Find​::find() on Win32
which have a trailing *back*slash are neatly handled. That is, the
change ensures paths such as c​:\dir\/file are no longer generated.

Thank you. I have applied these as
a0b245d. I took the liberty of changing
capturing parentheses to (?​:...) to avoid triggering the pre-match copy
unnecessarily.

I messed up the commit and only applied half the File.pm patch. The
second half has been applied as b242981.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant