-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ext/XS-APItest/t/call_checker.t fails under Cygwin #10750
Comments
From @jdheddenCreated by @jdhedden'make test' produces the following in blead under Cygwin on Windows: ext/XS-APItest/t/call_checker..................................fail at Perl Info
|
From @iabynOn Thu, Oct 21, 2010 at 09:34:15AM -0700, Jerry D. Hedden wrote:
Hi Jerry, are you still seeing this failure? -- |
The RT System itself - Status changed from 'new' to 'open' |
From @jdheddenYes, the problem still exists. Here is the latest: ext/XS-APItest/t/call_checker................................fail On Wed, Mar 30, 2011 at 12:12, Dave Mitchell <davem@iabyn.com> wrote:
|
From zefram@fysh.orgJerry D. Hedden wrote:
Unless we have a Win32 linker wizard in the house, I suggest that we -zefram |
From @janduboisOn Fri, 01 Apr 2011, Zefram wrote:
I assume you meant Cygwin, not Win32. I have fixed this same issue for MSWin32 with commit ad6ab6c, http://perl5.git.perl.org/perl.git/commitdiff/ad6ab6c50 of course wrapped with: #if defined(__CYGWIN__) || defined(WIN32) It needs confirmation from Jerry and/or Reini that this actually solves Cheers, |
From @obraOn Fri 1.Apr'11 at 18:11:48 -0700, Jan Dubois wrote:
If we think it works, I'd rather the fix than skipping the test. |
From @rurban2011/4/2 Jan Dubois <jand@activestate.com>:
Oops. This is a rather tricky change, which will need some testing Jerry, can you do this? |
From @jdheddenOn Sat, Apr 2, 2011 at 04:20, Reini Urban <rurban@x-ray.at> wrote:
I took a look at this, but I'm not able to figure out the intricacies of how to
|
From zefram@fysh.orgJerry D. Hedden wrote:
I've just uploaded a CPAN module that provides cv_set_call_checker() and -zefram |
From @janduboisOn Sat, 02 Apr 2011, Jerry D. Hedden wrote:
Hmm, I thought it would be straight-forward to move the definitions
Ok, ok, I'll try it myself then. I've never built Perl with Cygwin
I don't think this is necessary for this change. Cheers, |
From @janduboisOn Sun, 03 Apr 2011, Jan Dubois wrote:
Looks like it isn't building with Cygwin for me at all: $ git clone git://perl5.git.perl.org/perl.git perl [...] make[1]: *** No rule to make target `../../cygperl5_14_0.dll', needed by `../../ README.cygwin kind of leads me to expect that the above should have worked... Cheers, PS: Just in case this is somehow relevant: $ cygcheck.exe -s Cygwin Configuration Diagnostics Windows XP Professional Ver 5.1 Build 2600 Service Pack 3 Path: C:\cygwin\usr\local\bin Output from C:\cygwin\bin\id.exe SysDir: C:\WINDOWS\system32 USER = 'Jan' Use '-r' to scan registry obcaseinsensitive set to 1 Cygwin installations found in the registry: a: fd N/A N/A C:\cygwin / system binary,auto Found: C:\cygwin\bin\awk 15k 2009/12/27 C:\cygwin\bin\cygattr-1.dll No Cygwin services found. Cygwin Package Information |
From vadim.konovalov@alcatel-lucent.com
I have no better idea on why it fails, My build was okay, for both 5-13-11 and for latest git at Is the file cygperl5_14_0.dll created on your system? for the record, here is my cygwin version (I know, it is a little bit old) : Cygwin DLL version info:
Best regards, |
From @janduboisOn Mon, 04 Apr 2011, Konovalov, Vadim (Vadim)** CTR ** wrote:
I don't think it is clock skew.
No, it is not created at all.
My builds were running on a newly created VM with the latest Cygwin 1.7.x installed. I've now tried to build using the "unsupported legacy version" 1.5 (on Failed 10 tests out of 2039, 99.51% okay. So given the general state of Cygwin support in blead I don't think it I'll be happy to try to fix the call_checker.t failure once the overall Cheers, |
From @rurban2011/4/4 Jan Dubois <jand@activestate.com>:
The necessary fixes are still in my cygwin branch on github.com, and will |
From @obraI'm removing this ticket as an RC blocker for 5.14 based on Jan's comments. |
From @obraOn Wed 6.Apr'11 at 13:05:10 +0200, Reini Urban wrote:
I'm glad it's "better" and sorry it's not yet "good" -- After 5.14, what -jesse |
From vadim.konovalov@alcatel-lucent.com
given that currently cygwin does not even build perl - at least some portions of Reini's patch should be applied. I am fine with some failing tests, but it will be very unlucky to be not able play with 5.14.0 on cygwin at all. in this patch, 'm' modifier looks strange n the lines: but I believe it is some copy-paste from elsewhere. Best regards, |
From @nwc10On Mon, Apr 11, 2011 at 09:26:05AM +0200, Konovalov, Vadim (Vadim)** CTR ** wrote:
Hangon. We're getting conflicting information here. If Cygwin doesn't build What is different about your Cygwin?
Aha. That code in that patch: http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2010-08/msg00714.html It's actually stalled on an (*acknowledged* - "sure") request for a clearer http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2010-08/msg00719.html Given that the original proposed commit message was this: part1: support the standard cyg dll prefix, which is e.g. needed for FFI's. which doesn't act as a clear summary of the intent to anyone unfamiliar with [Actually, it looks like the original patch should be *two* patches each with Nicholas Clark |
From vadim.konovalov@alcatel-lucent.com
I was able to build on cygwin, Jan had unresolved external error in Cwd, as seen in this particular thread.
My cygwin is older (1.5.x)
indeed, Reini sent cumulative patch, I believe. Thanks for looking into this :) Vadim. |
From @tonycozOn Mon, Apr 11, 2011 at 10:57:50AM +0200, Konovalov, Vadim (Vadim)** CTR ** wrote:
I build ok on 1.7.x, thought some tests fail or get stuck. Tony |
From zefram@fysh.orgJan Dubois wrote:
I can now confirm that this is the correct fix. Due to debugging the For the use of modules (such as D-CC) that export C functions, it would #define PERL_BASE_CALLCONV EXTERN_C Adding PERL_{EX,IM}PORT_CALLCONV to the API should, of course, wait -zefram |
From @LeontOn Mon, Apr 11, 2011 at 12:02 PM, Zefram <zefram@fysh.org> wrote:
There is already another option to do this: the FUNCLIST option in Leon |
From zefram@fysh.orgLeon Timmermans wrote:
No, that tackles a different aspect of the job. It needs to be used FUNCLIST is used when building a shared library, to export symbols, __declspec(dllimport) is used when linking against a shared library, and Windows additionally has the complication, over Unix, of needing to refer -zefram |
From @LeontOn Mon, Apr 11, 2011 at 1:09 PM, Zefram <zefram@fysh.org> wrote:
I see. Linking on Windows continues to amaze me. Leon |
From @wchristianOn Mon, 11 Apr 2011 13:15:31 +0200, Leon Timmermans <fawaka@gmail.com> wrote:
The MinGW linker will also link against dlls and generate output that seems valid. The last time i tried that though, the result didn't manage to pass tests. I don't know if that means that linking against a dll is useless or needs extra massaging, but it doesn't seem outright impossible. -- |
From @janduboisOn Mon, 11 Apr 2011, Tony Cook wrote:
I could build blead with 1.5.x, although I got a bunch of test failures.
This one did not work for me at all, with a fresh copy of a pristine Cheers, |
From @tonycozOn Mon, Apr 11, 2011 at 10:34:19AM -0700, Jan Dubois wrote:
Just -Dusedevel. I've built blead with cygwin successfully on both Win7 and XP x64. I started a smoker for cygwin last night, but it gets stuck in tests But then, my NetBSD smoker gets stuck occasionally too. Tony |
From vadim.konovalov@alcatel-lucent.com
Jan, is your cygwin build any better?
Could it be the GCC version that makes difference? Reini told that after GCC upgrade he must declare all exportable mine is 3.4.4 Hmm... why its "ming"? Still,. simplest "hello.world.c" program is cygwin (not mingw) D:\cygwin\home\vkonovalov>dumpbin /dependents a.exe Dump of file a.exe File Type: EXECUTABLE IMAGE Image has the following dependencies: cygwin1.dll Regards, |
From vadim.konovalov@alcatel-lucent.com
this one still bothers me, as fresh cygwin does not build 5.13.11, Are there any cygwin smoke? I very much in favour to have cygwin supported,
Looks like there's no gcc 4.x.y for cygwin, Why they matter? Regards, |
From @obraOn Sun 24.Apr'11 at 22:53:22 +0200, Konovalov, Vadim (Vadim)** CTR ** wrote:
I'd really like too see regular cygwin smoking. I don't believe there is
It's too late for 5.14. I did work to apply everything from Reini's I agree 100% that it's a bad sign for Perl on cygwin that there isn't I'd love Perl to work great out of the box on every platform, but we -Jesse |
From @tonycozOn Wed, Apr 27, 2011 at 03:40:34PM +0800, Jesse Vincent wrote:
I'm now smoking blead. It tends to lock up in several tests though. Tony |
From vadim.konovalov@alcatel-lucent.com
What version of Test::Smoke do you use? Latest CPAN version seemingly fails, please see Regards, |
From @tonycozOn Wed, Apr 27, 2011 at 12:57:29PM +0200, Konovalov, Vadim (Vadim)** CTR ** wrote:
It works for me, though I clean PATH to just /bin:/usr/bin. eg. http://perl.develop-help.com/raw/?id=26157 Tony |
From vadim.konovalov@alcatel-lucent.com
Tony, you use Test-Smoke-1-44 version?
this does not help me either :( Now I suspect that I have broken one of gazillon CYGWIN Regards, |
From @tonycozOn Wed, Apr 27, 2011 at 01:49:12PM +0200, Konovalov, Vadim (Vadim)** CTR ** wrote:
Yes. Tony |
From @rurban2011/4/27 Tony Cook <tony@develop-help.com>:
I used Test-Smoke before but got tired that new perls were not So I started with adding git support, talked with the smoker guys, $ ls -l smokecurrent.log rurban@reini /usr/src/perl/.smoke |
From @tonycozOn Wed, Apr 27, 2011 at 10:37:45PM +0200, Reini Urban wrote:
I'm not sure what you mean here about new perls - I'm running it fine
I have my own -- fairly crude -- wrapper that extracts the HEAD of a Tony [1] when the platform is fast enough to support that |
From @greergaOn Thu, 28 Apr 2011, Tony Cook wrote:
My own git wrapper is https://github.com/greerga/smoke-me For blead and maint I just change the regex of branches it looks for. -- |
From @TuxOn Wed, 27 Apr 2011 22:37:45 +0200, Reini Urban <rurban@x-ray.at> wrote:
Test::Smoke is under construction at the moment. git support *is* Right now, that is however not our first goal. The maintainers of the Sorry for the silence.
-- |
From @tonycozOn Mon Apr 11 03:02:36 2011, zefram@fysh.org wrote:
I tried the following change: Inline Patchdiff --git a/perl.h b/perl.h
index 798e7b7..ba9f540 100644
--- a/perl.h
+++ b/perl.h
@@ -5019,15 +5019,26 @@ struct tempsym; /* defined in pp_pack.c */
#ifndef PERL_CALLCONV
# ifdef __cplusplus
-# define PERL_CALLCONV extern "C"
+# define PERL_BASE_CALLCONV extern "C"
# else
-# define PERL_CALLCONV
+# define PERL_BASE_CALLCONV
# endif
+#define PERL_EXPORT_CALLCONV PERL_BASE_CALLCONV
+#if defined(WIN32) || defined(__CYGWIN__)
+# define PERL_IMPORT_CALLCONV PERL_BASE_CALLCONV __declspec(dllimport)
+#else
+# define PERL_IMPORT_CALLCONV PERL_BASE_CALLCONV
#endif
#undef PERL_CKDEF
#undef PERL_PPDEF
#define PERL_CKDEF(s) PERL_CALLCONV OP *s (pTHX_ OP *o);
#define PERL_PPDEF(s) PERL_CALLCONV OP *s (pTHX);
+#if defined(PERL_CORE)
+# define PERL_CALLCONV PERL_EXPORT_CALLCONV
+#else
+# define PERL_CALLCONV PERL_IMPORT_CALLCONV
+#endif
+#endif
#ifdef MYMALLOC
# include "malloc_ctl.h"
I modified sub cflags in EU::MM_Unix to add a -DPERL_STATIC_EXT This time it failed linking the re extension, since Perl_regprop Tony |
From @tonycozOn Thu Oct 21 09:34:14 2010, jdhedden@cpan.org wrote:
I've made this test TODO on cygwin to make new failures more visible, the test is no longer failing, but this is still an issue. Tony |
Migrated from rt.perl.org#78502 (status was 'open')
Searchable as RT78502$
The text was updated successfully, but these errors were encountered: