B::Concise and -tree produces mangled output #10899
Comments
From @cpansproutSome time between 5.8.3 and 5.8.4, the -tree output format started getting extra line breaks. I suppose if one squints hard enough it might still look like a tree. Pint:perl.git-copy sprout$ perl5.8.3 -MO=Concise,-tree -e '{ print;} '<9>leave[1 ref]-+-<1>enter |-<2>nextstate(main 2 -e:1) `-<8>leaveloop `-lineseq `-<7>print `-ex-rv2sv -e syntax OK Flags: This perlbug was built using Perl 5.10.1 - Thu Sep 24 18:07:44 PDT 2009 Site configuration information for perl 5.8.4: Configured by sprout at Thu Jun 12 14:05:58 PDT 2008. Summary of my perl5 (revision 5 version 8 subversion 4) configuration: Locally applied patches: @INC for perl 5.8.4: Environment for perl 5.8.4: |
From @rurbanAttached patch fixes -MO=Concise,-tree for blead. Same fix should be applied back also. |
From @rurban0001-Fix-perl-80632-MO-Concise-tree-format.patchFrom fa71a7ff0911f9ed3c094ba836e136ecea077484 Mon Sep 17 00:00:00 2001
From: Reini Urban <rurban@x-ray.at>
Date: Mon, 13 Dec 2010 20:06:33 +0100
Subject: [PATCH] Fix [perl #80632] -MO=Concise,-tree format
Some time between 5.8.3 and 5.8.4, the -tree output
format started getting extra line breaks.
---
ext/B/B/Concise.pm | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ext/B/B/Concise.pm b/ext/B/B/Concise.pm
index 6d06956..fbc02ad 100644
--- a/ext/B/B/Concise.pm
+++ b/ext/B/B/Concise.pm
@@ -586,7 +586,7 @@ sub fmt_line { # generate text-line for op.
$text = "# $hr->{src}\n$text" if $show_src and $hr->{src};
chomp $text;
- return "$text\n" if $text ne "";
+ return "$text\n" if $text ne "" and $order ne "tree";
return $text; # suppress empty lines
}
--
1.7.2.3
|
The RT System itself - Status changed from 'new' to 'open' |
From @cpansproutOn Mon Dec 13 11:10:48 2010, rurban wrote:
Thank you. Applied as efef081. |
@cpansprout - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#80632 (status was 'resolved')
Searchable as RT80632$
The text was updated successfully, but these errors were encountered: