Carp is missing a dot

[p5pRT]

Migrated from rt.perl.org#106538 (status was 'resolved')

Searchable as RT106538$

[p5pRT]

From @cpansprout

This was brought up in #96672 but needs its own ticket​:

$ perl -e 'die'
Died at -e line 1.
$ perl -MCarp -e 'croak Died'
Died at -e line 1

Where did my dot go?

The hard part is deciding what to do about cluck().

---

Flags​:
  category=library
  severity=low

---

Site configuration information for perl 5.15.5​:

Configured by sprout at Sun Dec 18 11​:26​:14 PST 2011.

Summary of my perl5 (revision 5 version 15 subversion 5) configuration​:
  Snapshot of​: 5dca8ed
  Platform​:
  osname=darwin, osvers=10.5.0, archname=darwin-2level
  uname='darwin pint.local 10.5.0 darwin kernel version 10.5.0​: fri nov 5 23​:20​:39 pdt 2010; root​:xnu-1504.9.17~1release_i386 i386 '
  config_args='-de -Dusedevel -DDEBUGGING=-g'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=undef, use64bitall=undef, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include',
  optimize='-O3 -g',
  cppflags='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.2.1 (Apple Inc. build 5664)', gccosandvers=''
  intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib
  libs=-ldbm -ldl -lm -lutil -lc
  perllibs=-ldl -lm -lutil -lc
  libc=, so=dylib, useshrplib=false, libperl=libperl.a
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
  cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup -L/usr/local/lib -fstack-protector'

Locally applied patches​:
 

---

@​INC for perl 5.15.5​:
  /usr/local/lib/perl5/site_perl/5.15.5/darwin-2level
  /usr/local/lib/perl5/site_perl/5.15.5
  /usr/local/lib/perl5/5.15.5/darwin-2level
  /usr/local/lib/perl5/5.15.5
  /usr/local/lib/perl5/site_perl
  .

---

Environment for perl 5.15.5​:
  DYLD_LIBRARY_PATH (unset)
  HOME=/Users/sprout
  LANG=en_US.UTF-8
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/usr/bin​:/bin​:/usr/sbin​:/sbin​:/usr/local/bin​:/usr/X11/bin​:/usr/local/bin
  PERL_BADLANG (unset)
  SHELL=/bin/bash

[p5pRT]

From @cpansprout

On Sun Dec 18 19​:56​:10 2011, sprout wrote​:

This was brought up in #96672 but needs its own ticket​:

$ perl -e 'die'
Died at -e line 1.
$ perl -MCarp -e 'croak Died'
Died at -e line 1

Where did my dot go?

The hard part is deciding what to do about cluck().

In commit 879b0ca, Zefram has solved this by adding the dot to
messages but leaving it off for subsequent lines of cluck() output.

--

Father Chrysostomos

[p5pRT]

From [Unknown Contact. See original ticket]

On Sun Dec 18 19​:56​:10 2011, sprout wrote​:

This was brought up in #96672 but needs its own ticket​:

$ perl -e 'die'
Died at -e line 1.
$ perl -MCarp -e 'croak Died'
Died at -e line 1

Where did my dot go?

The hard part is deciding what to do about cluck().

In commit 879b0ca, Zefram has solved this by adding the dot to
messages but leaving it off for subsequent lines of cluck() output.

--

Father Chrysostomos

[p5pRT]

@cpansprout - Status changed from 'new' to 'resolved'

[p5pRT]

From zefram@fysh.org

Father Chrysostomos wrote​:

Where did my dot go?

Added to Carp as 879b0ca. This required
changing an autodie test, in partial violation of UPSTREAM=>"cpan".
autodie will need a new CPAN release with that change. (Also had to
change a handful of core-only tests.)

The hard part is deciding what to do about cluck().

I added the dot only to the base message, and left the stack trace
unaltered. I don't see what punctuation would be appropriate at the
end of every stack trace line, and I don't want to make the last line
of it different from the others.

-zefram

[p5pRT]

From @Leont

On Thu, Feb 2, 2012 at 5​:39 PM, Father Chrysostomos via RT
<perlbug-comment@​perl.org> wrote​:

In commit 879b0ca, Zefram has solved this by adding the dot to
messages but leaving it off for subsequent lines of cluck() output.

I'm worried this will break tests of CPAN modules that rely a little
too much on the exact error (probably including at least one of my
modules).

Leon

[p5pRT]

From zefram@fysh.org

Leon Timmermans wrote​:

I'm worried this will break tests of CPAN modules

There presumably will be a few. It's an easy fix for each. I think it's
an acceptable level of hassle. If you object, you've got two weeks to
render it contentious so that it has to be reverted. I'm holding off
on CPAN release for this reason.

-zefram

[p5pRT]

From @Leont

On Thu, Feb 2, 2012 at 6​:00 PM, Zefram <zefram@​fysh.org> wrote​:

There presumably will be a few.  It's an easy fix for each.  I think it's
an acceptable level of hassle.  If you object, you've got two weeks to
render it contentious so that it has to be reverted.  I'm holding off
on CPAN release for this reason.

I'm fine with updating my module, it's trivial indeed. I'm worried
though that the list of modules with this issue is larger than
expected. We'll see soon enough how big the issue is.

Leon

[p5pRT]

From @toddr

On Thu Feb 02 09​:17​:06 2012, LeonT wrote​:

On Thu, Feb 2, 2012 at 6​:00 PM, Zefram <zefram@​fysh.org> wrote​:

There presumably will be a few. �It's an easy fix for each. �I think it's
an acceptable level of hassle. �If you object, you've got two weeks to
render it contentious so that it has to be reverted. �I'm holding off
on CPAN release for this reason.

I'm fine with updating my module, it's trivial indeed. I'm worried
though that the list of modules with this issue is larger than
expected. We'll see soon enough how big the issue is.

So far, I've found needed test fixes in​: autodie, Error, Log4perl and counting.

[p5pRT]

From zefram@fysh.org

Todd Rinaldo via RT wrote​:

So far, I've found needed test fixes in​: autodie, Error, Log4perl and counting.

Not very many, then. This is looking viable.

-zefram

[p5pRT]

From @hvds

"Todd Rinaldo via RT" <perlbug-followup@​perl.org> wrote​:
:On Thu Feb 02 09​:17​:06 2012, LeonT wrote​:
:> On Thu, Feb 2, 2012 at 6​:00 PM, Zefram <zefram@​fysh.org> wrote​:
:> > There presumably will be a few. �It's an easy fix for each. �I think it's
:> > an acceptable level of hassle. �If you object, you've got two weeks to
:> > render it contentious so that it has to be reverted. �I'm holding off
:> > on CPAN release for this reason.
:>
:> I'm fine with updating my module, it's trivial indeed. I'm worried
:> though that the list of modules with this issue is larger than
:> expected. We'll see soon enough how big the issue is.
:
:So far, I've found needed test fixes in​: autodie, Error, Log4perl and counting.

One thing worth mentioning​: along the lines of Nick's recent patch to
separate two otherwise indistinguishable panics in perl core, there is
actually an advantage to being able to discover from where an error
message came.

Maybe the presence or absence of a trailing full-stop is not the ideal
way to signal provenance; but I think the general principle stands that
you actually do lose something by making the two identical.

Hugo

[p5pRT]

From @tsee

On 02/10/2012 05​:01 PM, Zefram wrote​:

Todd Rinaldo via RT wrote​:

So far, I've found needed test fixes in​: autodie, Error, Log4perl and counting.

Not very many, then. This is looking viable.

If somebody supplies me with two commits to run a CPAN smoke for, then I
can do that within a few days to get a more complete list.

--Steffen

[p5pRT]

From zefram@fysh.org

Steffen Mueller wrote​:

If somebody supplies me with two commits to run a CPAN smoke for,
then I can do that within a few days to get a more complete list.

Obvious choice is 62e9075 (before)
and 879b0ca (after).

-zefram

[p5pRT]

From @demerphq

On 11 February 2012 11​:15, <hv@​crypt.org> wrote​:

"Todd Rinaldo via RT" <perlbug-followup@​perl.org> wrote​:
:On Thu Feb 02 09​:17​:06 2012, LeonT wrote​:
:> On Thu, Feb 2, 2012 at 6​:00 PM, Zefram <zefram@​fysh.org> wrote​:
:> > There presumably will be a few. �It's an easy fix for each. �I think it's
:> > an acceptable level of hassle. �If you object, you've got two weeks to
:> > render it contentious so that it has to be reverted. �I'm holding off
:> > on CPAN release for this reason.
:>
:> I'm fine with updating my module, it's trivial indeed. I'm worried
:> though that the list of modules with this issue is larger than
:> expected. We'll see soon enough how big the issue is.
:
:So far, I've found needed test fixes in​: autodie, Error, Log4perl and counting.

One thing worth mentioning​: along the lines of Nick's recent patch to
separate two otherwise indistinguishable panics in perl core, there is
actually an advantage to being able to discover from where an error
message came.

Maybe the presence or absence of a trailing full-stop is not the ideal
way to signal provenance; but I think the general principle stands that
you actually do lose something by making the two identical.

I agree. I'm pretty sure at least one port of perl adds error codes to
all the error messages we provide. I have always thought that that is
a very useful thing. Especially when messages are localized, or
whatever. Id like to see a unique error code added to every error and
warning generating line of code in the core, and if I thought it would
be approved I'd do the work to make it happen.

cheers,
Yves

--
perl -Mre=debug -e "/just|another|perl|hacker/"