Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] f6722c7 fix wrong DB_File/t/db-btree.t #11905

Closed
p5pRT opened this issue Jan 24, 2012 · 10 comments
Closed

[PATCH] f6722c7 fix wrong DB_File/t/db-btree.t #11905

p5pRT opened this issue Jan 24, 2012 · 10 comments

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Jan 24, 2012

Migrated from rt.perl.org#108970 (status was 'rejected')

Searchable as RT108970$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 24, 2012

From @rurban

This is a bug report for perl from rurban@​cpanel.net,
generated with the help of perlbug 1.39 running under perl 5.15.7.

From f6722c7b0c76fd425930e632fda0224c0e27f1b2 Mon Sep 17 00​:00​:00 2001
From​: Reini Urban <rurban@​x-ray.at>
Date​: Tue, 24 Jan 2012 15​:05​:43 -0600
Subject​: [PATCH] fix wrong DB_File/t/db-btree.t


cpan/DB_File/t/db-btree.t | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

Inline Patch
diff --git a/cpan/DB_File/t/db-btree.t b/cpan/DB_File/t/db-btree.t
index 29c70a1..ab02407 100644
--- a/cpan/DB_File/t/db-btree.t
+++ b/cpan/DB_File/t/db-btree.t
@@ -566,9 +566,9 @@ sub ArrayCompare
  
     return 0 if @$a != @$b ;
  
-    foreach (1 .. length @$a)
+    foreach (0 .. @$a-1)
     {
-        return 0 unless $$a[$_] eq $$b[$_] ;
+        return 0 unless $$a[$_] eq $$b[$_];
     }
  
     1 ;
-- 
1.7.5.4

Flags​:
  category=library
  severity=low
  module=DB_File


Site configuration information for perl 5.15.7​:

Configured by rurban at Mon Jan 23 12​:43​:58 CST 2012.

Summary of my perl5 (revision 5 version 15 subversion 7) configuration​:
  Derived from​: ce334002dd31d29fbe9ccdb2c646ef2163bf6e56
  Platform​:
  osname=linux, osvers=3.0.0-1-amd64, archname=x86_64-linux-debug@​6d34176e
  uname='linux reini 3.0.0-1-amd64 #1 smp sun jul 24 02​:24​:44 utc 2011 x86_64 gnulinux '
  config_args='-de -Dusedevel -Dinstallman1dir=none -Dinstallman3dir=none -Dinstallsiteman1dir=none -Dinstallsiteman3dir=none -Dmksymlinks -DEBUGGING -Doptimize=-g3 -Uuseithreads -Accflags='-msse4.2' -Accflags='-march=corei7' -Dcf_email='rurban@​cpanel.net' -Dperladmin='rurban@​cpanel.net' -Duseshrplib'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-msse4.2 -march=corei7 -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-g3',
  cppflags='-msse4.2 -march=corei7 -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.6.1', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /lib /usr/lib /usr/lib/x86_64-linux-gnu /lib64 /usr/lib64
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
  libc=, so=so, useshrplib=true, libperl=libperl.so
  gnulibc_version='2.13'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E -Wl,-rpath,/usr/local/lib/perl5/5.15.7/x86_64-linux-debug@​6d34176e/CORE'
  cccdlflags='-fPIC', lddlflags='-shared -g3 -L/usr/local/lib -fstack-protector'

Locally applied patches​:
 


@​INC for perl 5.15.7​:
  /usr/local/lib/perl5/site_perl/5.15.7/x86_64-linux-debug@​6d34176e
  /usr/local/lib/perl5/site_perl/5.15.7
  /usr/local/lib/perl5/5.15.7/x86_64-linux-debug@​6d34176e
  /usr/local/lib/perl5/5.15.7
  /usr/local/lib/perl5/site_perl
  .


Environment for perl 5.15.7​:
  HOME=/home/rurban
  LANG=en_US.utf8
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/home/rurban/bin​:/usr/local/bin​:/usr/bin​:/bin​:/usr/local/games​:/usr/games
  PERL_BADLANG (unset)
  SHELL=/bin/bash

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 24, 2012

From @cpansprout

Forwarding....

On Tue Jan 24 13​:07​:02 2012, rurban@​cpanel.net wrote​:

This is a bug report for perl from rurban@​cpanel.net,
generated with the help of perlbug 1.39 running under perl 5.15.7.

From f6722c7b0c76fd425930e632fda0224c0e27f1b2 Mon Sep 17 00​:00​:00 2001
From​: Reini Urban <rurban@​x-ray.at>
Date​: Tue, 24 Jan 2012 15​:05​:43 -0600
Subject​: [PATCH] fix wrong DB_File/t/db-btree.t

---
cpan/DB_File/t/db-btree.t | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpan/DB_File/t/db-btree.t b/cpan/DB_File/t/db-btree.t
index 29c70a1..ab02407 100644
--- a/cpan/DB_File/t/db-btree.t
+++ b/cpan/DB_File/t/db-btree.t
@​@​ -566,9 +566,9 @​@​ sub ArrayCompare

 return 0 if @&#8203;$a \!= @&#8203;$b ;

- foreach (1 .. length @​$a)
+ foreach (0 .. @​$a-1)
{
- return 0 unless $$a[$_] eq $$b[$_] ;
+ return 0 unless $$a[$_] eq $$b[$_];
}

 1 ;

--

Father Chrysostomos

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 24, 2012

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 24, 2012

@cpansprout - Status changed from 'open' to 'rejected'

@p5pRT p5pRT closed this Jan 24, 2012
@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 24, 2012

From bug-DB_File@rt.cpan.org

<URL​: https://rt.cpan.org/Ticket/Display.html?id=74336 >

Thanks. Fix uploaded to CPAN in DB_File-1.825

Paul

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 25, 2012

From bug-DB_File@rt.cpan.org

<URL​: https://rt.cpan.org/Ticket/Display.html?id=74336 >

On Tue Jan 24 17​:36​:56 2012, PMQS wrote​:

Thanks. Fix uploaded to CPAN in DB_File-1.825

In perl only half of the fix appeared. Please compare my patch.

The first array elements $$a[0] are never checked still.
--
Reini Urban

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 25, 2012

From bug-DB_File@rt.cpan.org

<URL​: https://rt.cpan.org/Ticket/Display.html?id=74336 >

On Tue Jan 24 20​:28​:29 2012, RURBAN wrote​:

On Tue Jan 24 17​:36​:56 2012, PMQS wrote​:

Thanks. Fix uploaded to CPAN in DB_File-1.825

In perl only half of the fix appeared. Please compare my patch.

The first array elements $$a[0] are never checked still.

Oops! Well spotted. DB_File-1.825 now headed to CPAN.

Payl

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 25, 2012

From bug-DB_File@rt.cpan.org

<URL​: https://rt.cpan.org/Ticket/Display.html?id=74336 >

On Wed Jan 25 03​:16​:27 2012, PMQS wrote​:

On Tue Jan 24 20​:28​:29 2012, RURBAN wrote​:

On Tue Jan 24 17​:36​:56 2012, PMQS wrote​:

Thanks. Fix uploaded to CPAN in DB_File-1.825

In perl only half of the fix appeared. Please compare my patch.

The first array elements $$a[0] are never checked still.

Oops! Well spotted. DB_File-1.825 now headed to CPAN.

Should, of course, say thet DB_File-1.826 headed to CPAN

Paul

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 25, 2012

From @bingos

On Wed, Jan 25, 2012 at 03​:17​:48AM -0500, Paul Marquess via RT wrote​:

Should, of course, say thet DB_File-1.826 headed to CPAN

Updated in blead with commit b34385a

Many thanks.

--
Chris Williams
aka BinGOs
PGP ID 0x4658671F
http​://www.gumbynet.org.uk

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 25, 2012

From bug-DB_File@rt.cpan.org

<URL​: https://rt.cpan.org/Ticket/Display.html?id=74336 >

On Wed, Jan 25, 2012 at 03​:17​:48AM -0500, Paul Marquess via RT wrote​:

Should, of course, say thet DB_File-1.826 headed to CPAN

Updated in blead with commit b34385a

Many thanks.

--
Chris Williams
aka BinGOs
PGP ID 0x4658671F
http​://www.gumbynet.org.uk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant