Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pod2html 1.12 & 1.13 broken #11954

Closed
p5pRT opened this issue Feb 12, 2012 · 11 comments
Closed

pod2html 1.12 & 1.13 broken #11954

p5pRT opened this issue Feb 12, 2012 · 11 comments

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Feb 12, 2012

Migrated from rt.perl.org#110520 (status was 'resolved')

Searchable as RT110520$

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 12, 2012

From occitan@esperanto.org

It no longer accepts --libpods, breaking backwards compatibility with older
scripts and causing a headache for those that support more than one version of
Perl. This is too bad already, but worse it isn't even announced in
perl5156delta.pod, where it first broke and perl5157delta.pod just has a vague
mention of Pod​::Html. If you break things for your users, there should at
least be a migration howto! But I'd much prefer compatibility!

Around 5.8.7 you wrecked =item id`s (name`s at the time), and now you've done
it again. This breaks bookmarks and any attempt to link to something. Plain
sabotage!

What good is this​: <a
href="home/pfeiffer/makepp/cvs/pod/makepp_builtins.html">? Even though
--outfile goes to another directory it assumes links as an absolute path to
the pod dir, and on top of that it omits the leading slash. I had
--htmlroot=. anyway and now discovered --htmldir=$target_dir, but it doesn't help.

E<nbsp> gets output as Latin-1 char 0240 in contradiction to the <?xml
version="1.0" ?> header, which implies UTF8 and <meta
http-equiv="content-type" content="text/html; charset=utf-8" /> making Emacs
barf when reading the file.

What is this​: <span style="white-space​: nowrap;"><code>x y z</code></span>?
Why not simply <code style="white-space​: nowrap;">x y z</code> or even better
move that to css.

coralament / best Grötens / liebe Grüße / best regards / elkorajn salutojn
Daniel Pfeiffer

--
lerne / learn / apprends / lär dig / ucz się Esperanto​:
  http​://lernu.net / http​://ikurso.net

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 12, 2012

From occitan@esperanto.org

la 02/13/2012 12​:00 AM perlbug-followup@​perl.org skribis​:

You can view your ticket at
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=110520

And immediately I spot the next bug. In the past the body of =head1 NAME
became the title. Now it generates an empty title. If changing this is a
feature, it would break thousands of pods.

coralament / best Grötens / liebe Grüße / best regards / elkorajn salutojn
Daniel Pfeiffer

--
lerne / learn / apprends / lär dig / ucz się Esperanto​:
  http​://lernu.net / http​://ikurso.net

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 13, 2012

From @demerphq

On 13 February 2012 00​:00, Daniel Pfeiffer <perlbug-followup@​perl.org> wrote​:

# New Ticket Created by  Daniel Pfeiffer
# Please include the string​:  [perl #110520]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=110520 >

It no longer accepts --libpods, breaking backwards compatibility with older
scripts and causing a headache for those that support more than one version of
Perl.  This is too bad already, but worse it isn't even announced in
perl5156delta.pod, where it first broke and perl5157delta.pod just has a vague
mention of Pod​::Html.  If you break things for your users, there should at
least be a migration howto!  But I'd much prefer compatibility!

Around 5.8.7 you wrecked =item id`s (name`s at the time), and now you've done
it again.  This breaks bookmarks and any attempt to link to something.  Plain
sabotage!

What good is this​: <a
href="home/pfeiffer/makepp/cvs/pod/makepp_builtins.html">?  Even though
--outfile goes to another directory it assumes links as an absolute path to
the pod dir, and on top of that it omits the leading slash.  I had
--htmlroot=. anyway and now discovered --htmldir=$target_dir, but it doesn't help.

Who is "you" in this context?

Yves

--
perl -Mre=debug -e "/just|another|perl|hacker/"

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 13, 2012

The RT System itself - Status changed from 'new' to 'open'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 13, 2012

From occitan@esperanto.org

la 02/13/2012 12​:08 AM Daniel Pfeiffer skribis​:

la 02/13/2012 12​:00 AM perlbug-followup@​perl.org skribis​:

You can view your ticket at
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=110520

And immediately I spot the next bug. In the past the body of =head1 NAME
became the title. Now it generates an empty title. If changing this is a
feature, it would break thousands of pods.

Concretely I have tested this with
http​://makepp.cvs.sourceforge.net/viewvc/makepp/makepp/pod/makepp_functions.pod?revision=1.47
from http​://search.cpan.org/CPAN/authors/id/P/PF/PFEIFFER/makepp-2.0rc2.tgz .

This is hurting us badly because we massage the html output to provide a
pretty http​://makepp.sourceforge.net/2.0/ . The =item links are important,
because several pages are provided with a mini index, and it is accumulated
from all pages into http​://makepp.sourceforge.net/2.0/makepp_index.html . Now
version 2.0 is almost final and pod2html is not only breaking the backwards
compatibility. Because it is still in an early alpha phase, there is no way I
can adapt it to the upcoming Perl 5.16. and meanwhile the CPAN tests are
failing... And if we don't find a quick solution, CPAN testers will be
failing 5.16 with makepp. Or I'll have to bundle the old version with makepp
— not pretty!

Also switchover is not an option, because this beautification of html also
happens during local installation, and people might be using any Perl version
of their choice, or dictated by circumstance — e.g. my company still uses
5.8.8 and requires a thorough test planned for this year to update.

coralament / best Grötens / liebe Grüße / best regards / elkorajn salutojn
Daniel Pfeiffer

--
lerne / learn / apprends / lär dig / ucz się Esperanto​:
  http​://lernu.net / http​://ikurso.net

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented May 4, 2012

From @smpeters

On Sun Feb 12 15​:00​:34 2012, occitan@​esperanto.org wrote​:

It no longer accepts --libpods, breaking backwards compatibility with
older
scripts and causing a headache for those that support more than one
version of
Perl. This is too bad already, but worse it isn't even announced in
perl5156delta.pod, where it first broke and perl5157delta.pod just has
a vague
mention of Pod​::Html. If you break things for your users, there
should at
least be a migration howto! But I'd much prefer compatibility!

Around 5.8.7 you wrecked =item id`s (name`s at the time), and now
you've done
it again. This breaks bookmarks and any attempt to link to something.
Plain
sabotage!

What good is this​: <a
href="home/pfeiffer/makepp/cvs/pod/makepp_builtins.html">? Even
though
--outfile goes to another directory it assumes links as an absolute
path to
the pod dir, and on top of that it omits the leading slash. I had
--htmlroot=. anyway and now discovered --htmldir=$target_dir, but it
doesn't help.

E<nbsp> gets output as Latin-1 char 0240 in contradiction to the <?xml
version="1.0" ?> header, which implies UTF8 and <meta
http-equiv="content-type" content="text/html; charset=utf-8" /> making
Emacs
barf when reading the file.

What is this​: <span style="white-space​: nowrap;"><code>x y
z</code></span>?
Why not simply <code style="white-space​: nowrap;">x y z</code> or even
better
move that to css.

coralament / best Gr�tens / liebe Gr��e / best regards / elkorajn
salutojn
Daniel Pfeiffer

With change 978af2c, --libpods now is an accepted option. It is
non-functional, however, and warns that --libpods is no longer supported.

The remaining issues regarding the title still require some work.

Steve

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented May 4, 2012

From @rjbs

* Steve Peters via RT <perlbug-followup@​perl.org> [2012-05-04T11​:59​:50]

With change 978af2c, --libpods now is an accepted option. It is
non-functional, however, and warns that --libpods is no longer supported.

For the record, the change is actually 31c32f2. Thanks!

--
rjbs

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Dec 13, 2017

From zefram@fysh.org

The issue of "E<nbsp>" being emitted as a Latin-1 character in UTF-8
context was fixed some time ago​: it is now emitted as " ".

I have restored automatic titling in commit
38e30ca.

I believe that resolves all the actual bugs reported on this ticket,
which can now be closed.

-zefram

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Dec 14, 2017

@cpansprout - Status changed from 'open' to 'pending release'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Jun 23, 2018

From @khwilliamson

Thank you for filing this report. You have helped make Perl better.

With the release yesterday of Perl 5.28.0, this and 185 other issues have been
resolved.

Perl 5.28.0 may be downloaded via​:
https://metacpan.org/release/XSAWYERX/perl-5.28.0

If you find that the problem persists, feel free to reopen this ticket.

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Jun 23, 2018

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.