Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental warning for given/~~ before 5.20.0 #12809

Closed
p5pRT opened this issue Feb 25, 2013 · 5 comments
Closed

experimental warning for given/~~ before 5.20.0 #12809

p5pRT opened this issue Feb 25, 2013 · 5 comments
Labels

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Feb 25, 2013

Migrated from rt.perl.org#116913 (status was 'resolved')

Searchable as RT116913$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 25, 2013

From @rjbs

The behavior of given/when/~~ are likely to change in perl 5.20.0​: either smart
match will be removed or stripped down. In light of this, users of these
features should be warned. A category "experimental​::smartmatch" warning
should be issued for these features when they are used.

--
rjbs

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 25, 2013

From @Hugmeir

On Sun Feb 24 19​:20​:57 2013, rjbs wrote​:

The behavior of given/when/~~ are likely to change in perl 5.20.0​:
either smart
match will be removed or stripped down. In light of this, users of
these
features should be warned. A category "experimental​::smartmatch"
warning
should be issued for these features when they are used.

https://github.com/Hugmeir/utf8mess/tree/experimental_given_when_smartmatch

The branch introduces three new warnings​:

given is experimental
when is experimental
Smartmatch is experimental

The three are under the experimental​::smartmatch category. There's a
handful of commits that remove uses of smartmatch throughout the core,
and then a big one that introduces the three warnings & disables them in
the tests.

The last commit are changes to autodie to silence the warning, but that
has upstream => cpan, so it shouldn't be merged.

--
--hugmeir

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 25, 2013

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 27, 2013

From @khwilliamson

Thanks, applied as commits starting with
44bda13
--
Karl Williamson

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 27, 2013

@khwilliamson - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this Mar 27, 2013
@p5pRT p5pRT added the Severity Low label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant