-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perlsource.pod: Misleading discussion of what should go into ext/ #13475
Comments
From @jkeenanI posed this question on perl.perl5porters earlier this year and got no pod/perlsource.pod describes the 'ext/' directory in the Perl 5 ##### This directory contains XS-using modules which are only released as This is misleading because (as of my last count in May 2013), there are Errno My sense is that, until relatively recent times, 'ext/' always held Note that in the following paragraph in perlsource.pod, we have this: ##### This directory is for dual-life modules where the blead source is It seems to me that the 7 non-XS using libraries under ext/ could just If we can get a decision on what the layout should be, I will either: Choose! Thank you very much. Now, I could certainly live with a description of 'ext/' as holding |
From @jkeenan$ perl -V Characteristics of this binary (from libperl): |
From @cpansproutOn Mon Dec 16 19:24:18 2013, jkeen@verizon.net wrote:
At least to me, the main distinction between dist and ext is that code under dist needs to work with older versions, whereas we can do whatever we like (use new shiny features) with ext. Maybe that could be incorporated into a new description for ext. -- Father Chrysostomos |
The RT System itself - Status changed from 'new' to 'open' |
From @bulk88On Mon Dec 16 19:24:18 2013, jkeen@verizon.net wrote:
Win32CORE has a .c files with xsubs. So it basically has XS. Pod-Html should be on CPAN or dual lifed. Pod-Html, which is used by ActivePerl for their pretty (CSSed) HTML docs, suffered some bug fixes and some regressions between 5.14 and 5.16. I'm not sure where to even file a ticket, or if it can ever be fixed since Pod-Html is not distributed on CPAN and therefore isn't upgradable. |
From @tonycozOn Mon Dec 16 19:24:18 2013, jkeen@verizon.net wrote:
I believe this is the correct way to handle it. On Mon Dec 16 22:53:48 2013, bulk88 wrote:
I don't think anyone would object to you packaging Pod-Html for CPAN. Tony |
From @rjbs* Tony Cook via RT <perlbug-followup@perl.org> [2013-12-17T17:57:53]
I would owe the packager a beer, juice, or other beverage or snack. -- |
From @jkeenanOn 12/19/13 9:34 PM, Ricardo Signes wrote:
The discussion has gone a bit off topic. I'd like to discuss Pod-Html, rjbs: Do you have feedback on my OP on pod/perlsource.pod and on Father Thank you very much. |
From @rjbsOn Fri Dec 20 12:55:22 2013, jkeen@verizon.net wrote:
Yes: I agree with your suggestion and with FC's elaboration. -- |
From @jkeenanOn Mon Feb 10 14:47:51 2014, rjbs wrote:
Okay, then let's get concrete. Please evaluate the patch attached. (I'll apply it to blead in 7 days unless there is an objection.) Thank you very much. |
From @jkeenan120808-0001-Clarify-distinction-between-contents-of-dist-and-ext.patchFrom 549fcc75f5665e162dd09e8d3eb5e5a66f69f428 Mon Sep 17 00:00:00 2001
From: James E Keenan <jkeenan@cpan.org>
Date: Tue, 11 Feb 2014 01:50:47 +0100
Subject: [PATCH] Clarify distinction between contents of dist/ and ext/.
For: RT #120808
---
pod/perlsource.pod | 21 +++++++++++++--------
1 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/pod/perlsource.pod b/pod/perlsource.pod
index 81e3e94..aa351dd 100644
--- a/pod/perlsource.pod
+++ b/pod/perlsource.pod
@@ -46,15 +46,20 @@ their tests, unlike other core modules.
=item * F<ext/>
-This directory contains XS-using modules which are only released as
-part of the core. These modules generally have their F<Makefile.PL> and
-are laid out more like a typical CPAN module.
+Like F<lib/>, this directory contains modules which are only released
+as part of the core. Unlike F<lib/>, however, a module under F<ext/>
+generally has a CPAN-style directory- and file-layout and its own
+F<Makefile.PL>. There is no expectation that a module under F<ext/>
+will work with earlier versions of Perl 5. Hence, such a module may
+take full advantage of syntactical and other improvements in Perl 5
+blead.
=item * F<dist/>
This directory is for dual-life modules where the blead source is
canonical. Note that some modules in this directory may not yet have
-been released separately on CPAN.
+been released separately on CPAN. Modules under F<dist/> are expected
+to work with earlier versions of Perl 5.
=item * F<cpan/>
@@ -118,10 +123,10 @@ other directories.
=item * F<t/opbasic/>
-Tests for perl's built in functions which, like those in F<t/op/>, do not fit
-into any of the other directories, but which, in addition, cannot use
-F<t/test.pl>,as that program depends on functionality which the
-test file itself is testing.
+Tests for perl's built in functions which, like those in F<t/op/>, do
+not fit into any of the other directories, but which, in addition,
+cannot use F<t/test.pl>,as that program depends on functionality which
+the test file itself is testing.
=item * F<t/re/>
--
1.7.1
|
From @rjbsOn Mon Feb 10 18:29:49 2014, jkeenan wrote:
Looks fine to me. If I were to pick a nit, it would be this: +been released separately on CPAN. Modules under F<dist/> are expected I might say "will often work" or "should make an effort to work." The language "are expected" makes me wonder "expected by whom?" and whether it implies any obligation. I don't think there is a blanket obligation to support earlier perls, but that it we should not gratuitously cease to support them. At any rate, the patch is a marked improvement on the accuracy of the documentation. -- |
From @karenetheridgeOn Mon, Feb 10, 2014 at 06:29:49PM -0800, James E Keenan via RT wrote:
With these changes, will it be possible to distinguish (in, say, If yes, it would also be useful to enforce the directory distinctions by |
From @jkeenanOn Sun Feb 16 13:28:10 2014, perl@froods.org wrote:
No. But that's no change from the current situation, where dual-lifed modules may exist in either cpan/ or dist/. My patch is just a documentation patch and does not move any modules from one tree to another. The objective is simply to describe the contents of the various trees more accurately than pod/perlsource.pod does now. Thank you very much. |
From @jkeenanOn Fri Feb 14 18:06:56 2014, rjbs wrote:
Patch, incorporating rjbs's suggestion, was applied to blead in commit 259799c. Closing ticket. Any other issues concerning the directory structure should be raised on p5p list or in a new RT. Thank you very much. |
@jkeenan - Status changed from 'open' to 'resolved' |
From @steve-m-hayOn 16 February 2014 21:27, Karen Etheridge <perl@froods.org> wrote:
My understanding was that a module is dual-lived if and only if it has |
Migrated from rt.perl.org#120808 (status was 'resolved')
Searchable as RT120808$
The text was updated successfully, but these errors were encountered: