Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Module::CoreList 3.06, is_core is self-consistent test fails on 5.10.0 #13615

Closed
p5pRT opened this issue Feb 20, 2014 · 7 comments
Closed

In Module::CoreList 3.06, is_core is self-consistent test fails on 5.10.0 #13615

p5pRT opened this issue Feb 20, 2014 · 7 comments

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Feb 20, 2014

Migrated from rt.perl.org#121287 (status was 'resolved')

Searchable as RT121287$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 20, 2014

From paul@city-fan.org

$ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils​::Command​::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/corelist.t ...... ok
t/deprecated.t .... ok
t/find_modules.t .. ok
# Failed test 'is_core is self-consistent'
# at t/is_core.t line 10.
# Looks like you failed 1 test of 34.
t/is_core.t .......
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/34 subtests
t/pod.t ........... ok
t/utils.t ......... ok
Test Summary Report


t/is_core.t (Wstat​: 256 Tests​: 34 Failed​: 1)
  Failed test​: 2
  Non-zero exit status​: 1
Files=6, Tests=85, 3 wallclock secs ( 0.03 usr 0.01 sys + 2.22 cusr 0.02 csys = 2.28 CPU)
Result​: FAIL
Failed 1/6 test programs. 1/85 subtests failed.

This appears to be due to is_core not being able to follow the delta tree back from 5.01, apparently due to trailing zeroes in $], which is 5.010000. The following patch works around the issue and doesn't seem to break any other perls I've tried​:

--- lib/Module/CoreList.pm
+++ lib/Module/CoreList.pm
@​@​ -9603,7 +9603,7 @​@​
  # of releases from 5 to the specified release, and follow the module's version(s)
  # along that path.
  my @​releases = ($perl_version);
- my $rel = $perl_version;
+ my $rel = $perl_version + 0; # numify and drop trailing zeroes
  while (defined($rel)) {
  $rel = $delta{$rel}->{delta_from};
  unshift(@​releases, $rel) if defined($rel);

Loading

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 20, 2014

From @tonycoz

On Thu Feb 20 07​:05​:00 2014, pghmcfc wrote​:

Test Summary Report
-------------------
t/is_core.t (Wstat​: 256 Tests​: 34 Failed​: 1)
Failed test​: 2
Non-zero exit status​: 1
Files=6, Tests=85, 3 wallclock secs ( 0.03 usr 0.01 sys + 2.22 cusr
0.02 csys = 2.28 CPU)
Result​: FAIL
Failed 1/6 test programs. 1/85 subtests failed.

This appears to be due to is_core not being able to follow the delta
tree back from 5.01, apparently due to trailing zeroes in $], which is
5.010000. The following patch works around the issue and doesn't seem
to break any other perls I've tried​:

There's a different fix for this in blead, committed as part of http​://perl5.git.perl.org/perl.git/commit/baca455461522d62967cae39a044a49583cb6aae

@​@​ -10786,6 +10805,7 @​@​ for my $version (sort { $a <=> $b } keys %deprecated) {
$released{'5.000'} = $released{5};
$version{'5.000'} = $version{5};

+_create_aliases(\%delta);
_create_aliases(\%released);
_create_aliases(\%version);
_create_aliases(\%deprecated);

Does this change to lib/Module/CoreList.pm also fix it for you?

Tony

Loading

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 20, 2014

The RT System itself - Status changed from 'new' to 'open'

Loading

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 21, 2014

From paul@city-fan.org

On Thu Feb 20 13​:18​:09 2014, tonyc wrote​:

Does this change to lib/Module/CoreList.pm also fix it for you?

Yes, it does.

Loading

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 23, 2014

From paul@city-fan.org

On Thu, 20 Feb 2014 13​:18​:09 -0800
"Tony Cook via RT" <perlbug-followup@​perl.org> wrote​:

On Thu Feb 20 07​:05​:00 2014, pghmcfc wrote​:

Test Summary Report
-------------------
t/is_core.t (Wstat​: 256 Tests​: 34 Failed​: 1)
Failed test​: 2
Non-zero exit status​: 1
Files=6, Tests=85, 3 wallclock secs ( 0.03 usr 0.01 sys + 2.22
cusr 0.02 csys = 2.28 CPU)
Result​: FAIL
Failed 1/6 test programs. 1/85 subtests failed.

This appears to be due to is_core not being able to follow the delta
tree back from 5.01, apparently due to trailing zeroes in $], which
is 5.010000. The following patch works around the issue and doesn't
seem to break any other perls I've tried​:

There's a different fix for this in blead, committed as part of
http​://perl5.git.perl.org/perl.git/commit/baca455461522d62967cae39a044a49583cb6aae

@​@​ -10786,6 +10805,7 @​@​ for my $version (sort { $a <=> $b } keys
%deprecated) { $released{'5.000'} = $released{5};
$version{'5.000'} = $version{5};

+_create_aliases(\%delta);
_create_aliases(\%released);
_create_aliases(\%version);
_create_aliases(\%deprecated);

Does this change to lib/Module/CoreList.pm also fix it for you?

Yes, it does.

Cheers, Paul.

Loading

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 23, 2014

From @tonycoz

On Sun Feb 23 12​:52​:49 2014, pghmcfc wrote​:

On Thu, 20 Feb 2014 13​:18​:09 -0800
"Tony Cook via RT" <perlbug-followup@​perl.org> wrote​:

On Thu Feb 20 07​:05​:00 2014, pghmcfc wrote​:

Test Summary Report
-------------------
t/is_core.t (Wstat​: 256 Tests​: 34 Failed​: 1)
Failed test​: 2
Non-zero exit status​: 1
Files=6, Tests=85, 3 wallclock secs ( 0.03 usr 0.01 sys + 2.22
cusr 0.02 csys = 2.28 CPU)
Result​: FAIL
Failed 1/6 test programs. 1/85 subtests failed.

This appears to be due to is_core not being able to follow the
delta
tree back from 5.01, apparently due to trailing zeroes in $], which
is 5.010000. The following patch works around the issue and doesn't
seem to break any other perls I've tried​:

There's a different fix for this in blead, committed as part of
http​://perl5.git.perl.org/perl.git/commit/baca455461522d62967cae39a044a49583cb6aae

@​@​ -10786,6 +10805,7 @​@​ for my $version (sort { $a <=> $b } keys
%deprecated) { $released{'5.000'} = $released{5};
$version{'5.000'} = $version{5};

+_create_aliases(\%delta);
_create_aliases(\%released);
_create_aliases(\%version);
_create_aliases(\%deprecated);

Does this change to lib/Module/CoreList.pm also fix it for you?

Yes, it does.

Cheers, Paul.

BinGOS has released 3.07 to CPAN which includes this fix.

So resolving this ticket.

Tony

Loading

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 23, 2014

@tonycoz - Status changed from 'open' to 'resolved'

Loading

@p5pRT p5pRT closed this Feb 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant