Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.21.3-440-ga730e3f breaks TYPESTER/NgxQueue-0.02.tar.gz #14678

Closed
p5pRT opened this issue Apr 28, 2015 · 5 comments
Closed

Bleadperl v5.21.3-440-ga730e3f breaks TYPESTER/NgxQueue-0.02.tar.gz #14678

p5pRT opened this issue Apr 28, 2015 · 5 comments
Labels

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Apr 28, 2015

Migrated from rt.perl.org#124409 (status was 'resolved')

Searchable as RT124409$

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented Apr 28, 2015

From @andk

Another one from Slaven.

bisect


commit a730e3f
Author​: Jarkko Hietaniemi <jhi@​iki.fi>
Date​: Thu Sep 4 09​:08​:33 2014 -0400

  Use sizeof() in UNUSED_ARG and UNUSED_VAR to avoid accessing the values.

rt.cpan ticket


https://rt.cpan.org/Ticket/Display.html?id=104018

No fail reports yet on cpantesters.

perl -V


Summary of my perl5 (revision 5 version 21 subversion 4) configuration​:
  Commit id​: a730e3f
  Platform​:
  osname=linux, osvers=3.16.0-4-amd64, archname=x86_64-linux-thread-multi
  uname='linux k83 3.16.0-4-amd64 #1 smp debian 3.16.7-ckt9-1 (2015-04-08) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.21.3-440-ga730e3f/9980 -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Duseithreads -Uuselongdouble -DDEBUGGING=-g'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2',
  optimize='-O2 -g',
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.9.2', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.9/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
  libc=libc-2.19.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.19'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES MULTIPLICITY PERLIO_LAYERS
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
  PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP
  PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
  USE_ITHREADS USE_LARGE_FILES USE_LOCALE
  USE_LOCALE_COLLATE USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC USE_LOCALE_TIME USE_PERLIO
  USE_PERL_ATOF USE_REENTRANT_API
  Built under linux
  Compiled at Apr 28 2015 04​:59​:02
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.3-440-ga730e3f/9980/lib/site_perl/5.21.4/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.3-440-ga730e3f/9980/lib/site_perl/5.21.4
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.3-440-ga730e3f/9980/lib/5.21.4/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.3-440-ga730e3f/9980/lib/5.21.4
  .

--
andreas

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented May 12, 2015

From @tonycoz

On Mon Apr 27 23​:05​:08 2015, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Another one from Slaven.

bisect
------
commit a730e3f
Author​: Jarkko Hietaniemi <jhi@​iki.fi>
Date​: Thu Sep 4 09​:08​:33 2014 -0400

Use sizeof() in UNUSED_ARG and UNUSED_VAR to avoid accessing the
values.

rt.cpan ticket
--------------
https://rt.cpan.org/Ticket/Display.html?id=104018

NgxQueue (ab)uses PERL_UNUSED_ARG() on expressions with side-effects, like​:

  PERL_UNUSED_VAR(SvREFCNT_inc(queue->data));

With the change above such expressions are no longer evaluated, and so the
several SvREFCNT_inc() calls in the code are not executed and the module
fails.

Reverting v5.21.3-440-ga730e3f allows the tests to pass.

I've supplied a patch upstream with a fix.

Tony

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented May 12, 2015

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented May 13, 2015

From @rjbs

meantime, added to Known Problems; ticket closed

--
rjbs

@p5pRT p5pRT closed this May 13, 2015
@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented May 13, 2015

@rjbs - Status changed from 'open' to 'resolved'

@p5pRT p5pRT added the Severity Low label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.