Configuring with -Accflags='-DAPPLLIB_EXP=\"/usr/libperl\"' broken in v5.22.0 [rt.cpan.org #125314] #14732
Comments
From @wolfsageCreated by wolfsage@gmail.com(Found by Infinity Interactive's https://twitter.com/tripside) On v5.22.0: mhorsfall@dumai:~/p5/perl$ cat INSTALL | grep LLIB | grep Acc mhorsfall@dumai:~/p5/perl$ sh Configure mhorsfall@dumai:~/p5/perl$ make -j 8 This used to work fine in v5.20.0. It looks like the surrounding echo @`sh cflags "optimize='-O2'" opmini.o` -DPERL_IS_MINIPERL Here's how it looks when it works: echo @`sh cflags "optimize='-O2'" opmini.o` -DPERL_IS_MINIPERL A bisect: mhorsfall@dory:~/p5/perl$ ../perl3/Porting/bisect.pl --start=v5.20.0 Led me to this: 57d2761 is the first bad commit Allow cflags.SH edits to ccflags to stick. :100755 100755 524dab15ad4e2b691ae4d762aa8dadbdc0160f47 Perl Info |
From glai@arubanetworks.comThis issue has also been brought up at: As mentioned, 57d2761 is the first bad commit. Diff at: http://www.nntp.perl.org/group/perl.perl5.changes/2014/06/msg41057.html Removing $myccflags from cflags.SH is a workaround: --- cflags.SH # Used to restore possible edits by cflags.SH. |
|
@jkeenan - Status changed from 'new' to 'open' |
From @jhiWould the attached patch work for you? |
2 similar comments
From @jhiWould the attached patch work for you? |
From @jhiWould the attached patch work for you? |
From @jhi0001-For-perl-126468-protect-quotes-in-ccflags.patchFrom 111bd177427ec912ef9d64a6d055ca5e9abc359d Mon Sep 17 00:00:00 2001
From: Jarkko Hietaniemi <jhi@iki.fi>
Date: Wed, 28 Oct 2015 07:56:23 -0400
Subject: [PATCH] For perl #126468: protect quotes in ccflags.
---
cflags.SH | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/cflags.SH b/cflags.SH
index f3e44ad..33c6c93 100755
--- a/cflags.SH
+++ b/cflags.SH
@@ -387,6 +387,9 @@ echo "cflags.SH: warn = $warn"
# Code to set any extra flags here.
extra=''
+# Protect double or single quotes.
+myccflags=`echo $ccflags | sed -e 's/"/\\\"/g' -e "s/'/\\\'/g"`
+
echo "Extracting cflags (with variable substitutions)"
# This section of the file will have variable substitutions done on it.
# Move anything that needs config subs from !NO!SUBS! section to !GROK!THIS!.
@@ -401,7 +404,8 @@ $startsh
# This file is generated by cflags.SH
# Used to restore possible edits by cflags.SH.
-myccflags="$ccflags"
+myccflags="$myccflags"
+
# Extra warnings, used e.g. for gcc.
warn="$warn"
# Extra standardness.
--
2.6.0
|
From @jhiCould you try testing the suggested patch? |
From @wolfsageOn Thu, Oct 29, 2015 at 6:51 AM, Jarkko Hietaniemi via RT
Worked for me, thanks! -- Matthew Horsfall (alh) |
From glai@arubanetworks.comMy reply did not seem to get through to Jarkko. Resending it. -Gerald
Yes, the attached patch works for me. Thanks, |
From glai@arubanetworks.com
Yes, the attached patch works for me. Thanks, |
|
@jhi - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#125314 (status was 'resolved')
Searchable as RT125314$
The text was updated successfully, but these errors were encountered: