[PATCH] Fix the Configure escape with usecrosscompile but no targethost #15126
Comments
From @ntyniThis is a bug report for perl from Niko Tyni <ntyni@debian.org>, Commit 97076f2 added a graceful exit to Configure when targethost is The attached patch makes the earlier check warn instead of croaking. The use case for this combination is supplying an external config.sh Flags: Site configuration information for perl 5.22.1: Configured by Debian Project at Sat Dec 26 07:28:43 UTC 2015. Summary of my perl5 (revision 5 version 22 subversion 1) configuration: Locally applied patches: @INC for perl 5.22.1: Environment for perl 5.22.1: |
From @ntyni0001-Fix-the-Configure-escape-with-usecrosscompile-but-no.patchFrom e801cc45d65ae4e62f15c08911cbd30971bbce6e Mon Sep 17 00:00:00 2001
From: Niko Tyni <ntyni@debian.org>
Date: Sun, 10 Jan 2016 22:35:53 +0200
Subject: [PATCH] Fix the Configure escape with usecrosscompile but no
targethost
Commit 97076f2 added a graceful exit to Configure when targethost is
not defined but usecrosscompile is. However, this is not reached because
there is a similar check a bit earlier that makes Configure bail out.
Make the earlier check warn instead of croaking.
The use case for this combination is supplying an external config.sh
suitable for the target platform, avoiding the need for configuration
probes.
---
Configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Configure b/Configure
index d5a7de3..df2bcda 100755
--- a/Configure
+++ b/Configure
@@ -2960,7 +2960,7 @@ $define|true|[yY]*)
*) echo "Using targetarch $targetarch." >&4 ;;
esac
case "$targethost" in
- '') echo "Targethost not defined." >&4; croak=y ;;
+ '') echo "Targethost not defined." >&4; croak=n ;;
*) echo "Using targethost $targethost." >&4
esac
locincpth=' '
--
2.6.4
|
From @TuxOn Sun, 10 Jan 2016 12:51:38 -0800, Niko Tyni (via RT)
Easy change, but I would like to hear the voices of the people that use -- |
|
The RT System itself - Status changed from 'new' to 'open' |
From @tonycozOn Sun Jan 10 23:46:58 2016, hmbrand wrote:
I looked this over and tested with and without the patch and it makes sense. I've applied the patch as 23695c073f41fdac9d20d873827ba8b2a3dda7102. I noted it in perldelta as: C<Configure> now builds C<miniperl> and C<generate_uudmap> if you Tony |
|
@tonycoz - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release today of Perl 5.26.0, this and 210 other issues have been Perl 5.26.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
|
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#127234 (status was 'resolved')
Searchable as RT127234$
The text was updated successfully, but these errors were encountered: